Rename all methods IsEmpty to Empty to be consistent with all codebase #6409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgimeno
added
Type: Code Hygiene
jgimeno
requested review from
aaronc,
alessio,
alexanderbez,
clevinson and
fedekunze
as code owners
Codecov Report
@@ Coverage Diff @@
## master #6409 +/- ##
=======================================
Coverage 55.55% 55.55%
=======================================
Files 465 465
Lines 27526 27526
=======================================
Hits 15293 15293
Misses 11134 11134
Partials 1099 1099 |
alessio
suggested changes
Jun 11, 2020
There was a problem hiding this comment.
@alexanderbez comment on CHANGELOG needs addressing though, looks good otherwise
alessio
changed the title
…s-sdk into jonathan/unify-empty-method
alessio
approved these changes
Jun 11, 2020
alessio
reviewed
Jun 11, 2020
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
related: #6404
Looks like sometimes we use Empty, others IsEmpty, I think consistency is a nice thing to have, so here is a little bit of it!
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorer