Add TimeIotaMs to export GenesisFile #6510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgimeno
requested review from
aaronc,
alessio,
alexanderbez,
clevinson and
fedekunze
as code owners
alexanderbez
added
A:automerge
alexanderbez
approved these changes
Jun 25, 2020
…os-sdk into jonathan/export-time-genesis
|
@alexanderbez is it worth to have a test for this? |
Codecov Report
@@ Coverage Diff @@
## master #6510 +/- ##
=======================================
Coverage 56.36% 56.36%
=======================================
Files 470 470
Lines 28234 28234
=======================================
Hits 15913 15913
Misses 11195 11195
Partials 1126 1126 |
|
@jgimeno yes, good idea. I would extract out the logic that updates the doc and just verify the consensus params 👍 |
alessio
approved these changes
Jun 26, 2020
| return nil | ||
| }, | ||
| } | ||
|
|
||
| cmd.Flags().Int64(flagHeight, -1, "Export state from a particular height (-1 means latest height)") | ||
| cmd.Flags().Bool(flagForZeroHeight, false, "Export state to start at height zero (perform preproccessing)") | ||
| cmd.Flags().StringSlice(flagJailWhitelist, []string{}, "List of validators to not jail state export") | ||
| cmd.SetOut(cmd.OutOrStdout()) |
There was a problem hiding this comment.
We should try find a way to automatically call Set{Err,Out} for all commands at some point.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before we did not include the field time_iota_ms into the genesis file while exporting, now we do.
closes: ##6446
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorer