-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REST bank transfers fail due to encoding. #6536
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6536 +/- ##
==========================================
+ Coverage 56.83% 56.84% +0.01%
==========================================
Files 481 481
Lines 28911 28921 +10
==========================================
+ Hits 16432 16441 +9
+ Misses 11316 11314 -2
- Partials 1163 1166 +3 |
…mos/cosmos-sdk into jonathan/bank-accounts-transfer-test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 🎉
@@ -177,6 +177,8 @@ be used to retrieve the actual proposal `Content`. Also the `NewMsgSubmitProposa | |||
|
|||
### Bug Fixes | |||
|
|||
* (x/bank) [\#6536](https://github.com/cosmos/cosmos-sdk/pull/6536) Fix bug in `WriteGeneratedTxResponse` function used by multiple |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this bug fix entry is actually needed because it wasn't broken before... just noting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this @jgimeno !
That's a good point @aaronc, do you think is worth it to create a PR to remove the line? |
Sure, why not. I also have the feeling it would be nice to cleanup that CHANGELOG or summarize it somehow before the release. It's massive. |
Bank module REST endpoint bank/accounts/{addr}/transfers was returning invalid StdTx format.
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorer