Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REST bank transfers fail due to encoding. #6536

Merged
merged 22 commits into from
Jul 2, 2020

Conversation

jgimeno
Copy link
Contributor

@jgimeno jgimeno commented Jun 29, 2020

Bank module REST endpoint bank/accounts/{addr}/transfers was returning invalid StdTx format.

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@codecov
Copy link

codecov bot commented Jun 29, 2020

Codecov Report

Merging #6536 into master will increase coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #6536      +/-   ##
==========================================
+ Coverage   56.83%   56.84%   +0.01%     
==========================================
  Files         481      481              
  Lines       28911    28921      +10     
==========================================
+ Hits        16432    16441       +9     
+ Misses      11316    11314       -2     
- Partials     1163     1166       +3     

@jgimeno
Copy link
Contributor Author

jgimeno commented Jun 29, 2020

@aaronc I created the test, with the fix you included in #6467 it passes. You can close your PR, I will include the fix here apart from the test.

@jgimeno jgimeno marked this pull request as ready for review June 30, 2020 00:14
testutil/util.go Outdated Show resolved Hide resolved
x/bank/client/rest/tx_test.go Outdated Show resolved Hide resolved
x/bank/client/rest/tx_test.go Outdated Show resolved Hide resolved
@jgimeno jgimeno requested a review from alexanderbez July 1, 2020 09:29
CHANGELOG.md Outdated Show resolved Hide resolved
testutil/network.go Outdated Show resolved Hide resolved
types/rest/rest.go Outdated Show resolved Hide resolved
types/rest/rest.go Outdated Show resolved Hide resolved
types/rest/rest.go Outdated Show resolved Hide resolved
@jgimeno jgimeno requested a review from alexanderbez July 1, 2020 16:37
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 🎉

@alexanderbez alexanderbez added the A:automerge Automatically merge PR once all prerequisites pass. label Jul 1, 2020
@alessio alessio merged commit 8f96ec0 into master Jul 2, 2020
@alessio alessio deleted the jonathan/bank-accounts-transfer-test branch July 2, 2020 03:16
@@ -177,6 +177,8 @@ be used to retrieve the actual proposal `Content`. Also the `NewMsgSubmitProposa

### Bug Fixes

* (x/bank) [\#6536](https://github.com/cosmos/cosmos-sdk/pull/6536) Fix bug in `WriteGeneratedTxResponse` function used by multiple
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this bug fix entry is actually needed because it wasn't broken before... just noting.

Copy link
Member

@aaronc aaronc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @jgimeno !

@jgimeno
Copy link
Contributor Author

jgimeno commented Jul 2, 2020

That's a good point @aaronc, do you think is worth it to create a PR to remove the line?

@aaronc
Copy link
Member

aaronc commented Jul 2, 2020

That's a good point @aaronc, do you think is worth it to create a PR to remove the line?

Sure, why not. I also have the feeling it would be nice to cleanup that CHANGELOG or summarize it somehow before the release. It's massive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants