Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add exempt issue labels #6602

Merged
merged 3 commits into from
Jul 5, 2020
Merged

add exempt issue labels #6602

merged 3 commits into from
Jul 5, 2020

Conversation

tac0turtle
Copy link
Member

No description provided.

@alessio
Copy link
Contributor

alessio commented Jul 4, 2020

Please add launchpad to the list as well

@tac0turtle
Copy link
Member Author

this repo really needs to clean up its labels, it has 78...

@tac0turtle tac0turtle force-pushed the marko/exempt_issues branch from a75c3e7 to 5dd8c94 Compare July 4, 2020 18:19
@alessio
Copy link
Contributor

alessio commented Jul 4, 2020

Please add launchpad to the list as well

Sorry @marbar3778, I take it back. There is already a 0.39 LTS.

And I agree, here is a list of labels that IMO we should let go:

  • API: what API? Go API? REST API? Lacks a description. And frankly this is an SDK, nealry everything we do is about some APIs.
  • build, ci and tooling should be merged. tooling sound the most generic and appropriate to me
  • dev-ux, client-ux should be merged into a single UserExperience (developers are a subset of users)
  • baseapp, crypto, keys, kvstore, types (pointless, we should just use a core label for all the SDK's core packages - meaning everything that does not live in x/)
  • either feature or feature-request
  • nice-to-have (if we want to keep track of bug's priority to get better at prioritization then we should copy from tendermint, see the P: labels)
  • question (this label begets many indeed)
  • refactor (never managed to understand the value added by this label)
  • non-determinism means nothing, and in fact it has been used only 10 times. If a bug breaks determinism, then it should be tagged bug and P: critical.
  • vesting - only one issue open Create Vesting Account Message #4287

There might be more, what do people think?

@alexanderbez
Copy link
Contributor

IMHO we should just add pinned to those issues instead of having the config support a bunch of ad-hoc labels.

Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
@tac0turtle
Copy link
Member Author

tac0turtle commented Jul 5, 2020

we should merge this. there is chaos every morning i wake up lol

ill make a doc a doc for a label system and if accepted ill overhaul

@tac0turtle tac0turtle merged commit 4380d03 into master Jul 5, 2020
@tac0turtle tac0turtle deleted the marko/exempt_issues branch July 5, 2020 08:59
@alessio
Copy link
Contributor

alessio commented Jul 5, 2020

Yeah sorry @marbar3778, I've kinda hijacked the conversation. It's a great idea to create a doc, can you please incorporate this #6602 (comment) too? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants