Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client/flags: remove NewCompletionCmd() #6632

Merged
merged 2 commits into from
Jul 7, 2020

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Jul 7, 2020

The functionality was adopted tendermint upstream, see
tendermint/tendermint#4665


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

The functionality was adopted tendermint upstream, see
* tendermint/tendermint#4665
@alessio alessio force-pushed the alessio/remove-new-completion-cmd branch from 1e83bc7 to f3b553f Compare July 7, 2020 17:22
@alessio alessio marked this pull request as ready for review July 7, 2020 17:22
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK -- more code removal 🎉

@alexanderbez alexanderbez added the A:automerge Automatically merge PR once all prerequisites pass. label Jul 7, 2020
@codecov
Copy link

codecov bot commented Jul 7, 2020

Codecov Report

Merging #6632 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6632   +/-   ##
=======================================
  Coverage   57.73%   57.73%           
=======================================
  Files         496      496           
  Lines       29735    29735           
=======================================
  Hits        17167    17167           
  Misses      11332    11332           
  Partials     1236     1236           

@alessio alessio merged commit 57ac28c into master Jul 7, 2020
@alessio alessio deleted the alessio/remove-new-completion-cmd branch July 7, 2020 17:29
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
The functionality was adopted tendermint upstream, see
* tendermint/tendermint#4665
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants