Update auth cli commands #6717

sahith-narahari · 2020-07-14T12:07:46Z

Description

Ref: #6213
This is part of breakdown of #6216 into smaller PRs

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
Code follows the module structure standards.
Wrote unit and integration tests
Updated relevant documentation (docs/) or specification (x/<module>/spec/)
Added relevant godoc comments.
Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
Re-reviewed Files changed in the Github PR explorer
Review Codecov Report in the comment section below once CI passes

… into sahith/update-auth-cli

codecov · 2020-07-14T13:25:47Z

Codecov Report

Merging #6717 into master will increase coverage by 6.04%.
The diff coverage is 57.74%.

@@            Coverage Diff             @@
##           master    #6717      +/-   ##
==========================================
+ Coverage   55.60%   61.64%   +6.04%     
==========================================
  Files         457      511      +54     
  Lines       27440    31893    +4453     
==========================================
+ Hits        15257    19662    +4405     
+ Misses      11083    10676     -407     
- Partials     1100     1555     +455

…ate-auth-cli

lgtm-com · 2020-07-15T11:44:12Z

This pull request introduces 1 alert when merging d1eb8c1 into 6f928e1 - view on LGTM.com

new alerts:

1 for Useless assignment to local variable

…ate-auth-cli

… into sahith/update-auth-cli

…ate-auth-cli

aaronc · 2020-07-29T13:48:51Z

One comment I would make is that it has been suggested that we should use different encoding and application types and convert between the two. SignatureV2 is an example of that and it is a little more ergonomic in go code than the protobuf generated SignatureDescriptor. So having these two types is an attempt to practice this separation of types. I have also questioned the value of this separation and the overhead of that approach is I think evident here.

aaronc · 2020-07-29T14:02:08Z

One other subtle difference is between the PubKey interface and PublicKey type. Just that part alone would make moving from SignatureV2 to SignatureDescriptor in APIs quite cumbersome.

amaury1093

it has been suggested that we should use different encoding and application types and convert between the two

OK, this point also makes sense. in this case I'll approve, the migration to use the new TxConfig looks good 🎉

I still think some work can be done in terms of clarity with all these signing types, though maybe it's as simple as better naming. I can take a look in the next couple of days, after this PR gets merged.

aaronc · 2020-07-29T14:19:24Z

I still think some work can be done in terms of clarity with all these signing types, though maybe it's as simple as better naming. I can take a look in the next couple of days, after this PR gets merged.

Thanks @amaurymartiny. That would be great.

client/cmd.go

alexanderbez · 2020-07-29T14:21:33Z

types/tx/signing/signature.go

+// SignatureDataToSignatureDescriptorData converts a SignatureData to SignatureDescriptor_Data.
+// SignatureDescriptor_Data is considered an encoding type whereas SignatureData is used for
+// business logic.
+func SignatureDataToSignatureDescriptorData(data SignatureData) *SignatureDescriptor_Data {


I do agree here. I'd go with what @amaurymartiny stated or at the very least, change the nomenclature because it's confusing and the types clobber each other.

x/auth/client/cli/decode.go

x/auth/client/cli/encode.go

x/auth/client/cli/tx_sign.go

lgtm-com · 2020-07-29T18:45:18Z

This pull request introduces 1 alert when merging 423cbcb into 2da954f - view on LGTM.com

new alerts:

1 for Useless assignment to local variable

lgtm-com · 2020-07-29T19:07:36Z

This pull request introduces 1 alert when merging 0136c11 into 2da954f - view on LGTM.com

new alerts:

1 for Useless assignment to local variable

x/auth/client/cli/encode.go

…ith/update-auth-cli

aaronc · 2020-07-29T21:11:55Z

@alexanderbez I think we've addressed your comments here.

* add utils * update sign cmd * update multisign cmd * update sign batch cmd * update genutil cmd * add wrap tx builder * update gentx cli * update validate sigs cmd * fix lint * add flag reader to cli * update marshaler for batchscan * add register query server * update to master * remove depricated methods * fix keyring issue * update wraptx * Fix batch scan * fix register interfaces issue * update printOutput * Update Validate Sigs test * WIP on signature JSON * Cleanup * Cleanup * Test fixes * Test fixes * Fixes * WIP on tests * Fix gov tests * fix lint * fix MultiSign tests * fix tests * refactor tests * Cleanup * Address review comments * Update encode * Test fix * Rename SignData func * Fix lint * Fix lint * Revert ReadTxCommandFlags Co-authored-by: Aaron Craelius <aaron@regen.network> Co-authored-by: Aaron Craelius <aaronc@users.noreply.github.com>

sahith-narahari added 3 commits July 14, 2020 02:10

add utils

9b4a4a1

update sign cmd

eaeef54

Merge branch 'master' into sahith/update-auth-cli

b2c8997

aaronc mentioned this pull request Jul 14, 2020

Proto Any Tx migration #6213

Closed

27 tasks

sahith-narahari added 2 commits July 14, 2020 18:51

update multisign cmd

5abd7f1

Merge branch 'sahith/update-auth-cli' of github.com:cosmos/cosmos-sdk…

0a80caa

… into sahith/update-auth-cli

sahith-narahari added 3 commits July 14, 2020 20:30

update sign batch cmd

c2b4cc7

Merge branch 'master' of github.com:cosmos/cosmos-sdk into sahith/upd…

d9bbef8

…ate-auth-cli

update genutil cmd

d1eb8c1

aaronc mentioned this pull request Jul 15, 2020

Implement SIGN_MODE_DIRECT #6216

Closed

add wrap tx builder

2d5335b

blushi mentioned this pull request Jul 16, 2020

Migrate x/genutil to use TxConfig #6734

Merged

9 tasks

sahith-narahari added 11 commits July 19, 2020 00:51

Merge branch 'master' of github.com:cosmos/cosmos-sdk into sahith/upd…

cc2b7e0

…ate-auth-cli

update gentx cli

688e9cd

Merge branch 'master' of github.com:cosmos/cosmos-sdk into sahith/upd…

d4cbf42

…ate-auth-cli

Merge branch 'master' into sahith/update-auth-cli

425cbfe

Merge branch 'sahith/update-auth-cli' of github.com:cosmos/cosmos-sdk…

27a57a5

… into sahith/update-auth-cli

update validate sigs cmd

64f7aaf

fix lint

987af37

add flag reader to cli

167df15

update marshaler for batchscan

8f82734

add register query server

baebff4

Merge branch 'master' into sahith/update-auth-cli

ed36414

sahith-narahari mentioned this pull request Jul 20, 2020

Migrate validate-signatures cmd to SignatureV2 #6470

Closed

8 tasks

sahith-narahari added 4 commits July 21, 2020 01:11

Merge branch 'master' of github.com:cosmos/cosmos-sdk into sahith/upd…

3122b59

…ate-auth-cli

update to master

57c8798

remove depricated methods

39bc7f4

Merge branch 'master' of github.com:cosmos/cosmos-sdk into sahith/upd…

1afa4d3

…ate-auth-cli

amaury1093 approved these changes Jul 29, 2020

View reviewed changes

Merge branch 'master' into sahith/update-auth-cli

074ee7b

alexanderbez suggested changes Jul 29, 2020

View reviewed changes

sahith-narahari added 3 commits July 29, 2020 20:44

Merge branch 'master' into sahith/update-auth-cli

0c94f78

Address review comments

7771328

Update encode

423cbcb

aaronc and others added 2 commits July 29, 2020 14:54

Merge branch 'master' into sahith/update-auth-cli

d9b15df

Test fix

0136c11

alexanderbez mentioned this pull request Jul 29, 2020

cli: refactor flag reading #6884

Merged

9 tasks

sahith-narahari added 2 commits July 30, 2020 01:42

Rename SignData func

2073e3f

Fix lint

af89c16

aaronc reviewed Jul 29, 2020

View reviewed changes

x/auth/client/cli/encode.go Outdated Show resolved Hide resolved

aaronc and others added 4 commits July 29, 2020 16:17

Merge branch 'master' into sahith/update-auth-cli

c5d7181

Fix lint

c6a7353

Revert ReadTxCommandFlags

ecf0679

Merge remote-tracking branch 'origin/sahith/update-auth-cli' into sah…

8a4c583

…ith/update-auth-cli

alexanderbez approved these changes Jul 29, 2020

View reviewed changes

aaronc added the A:automerge Automatically merge PR once all prerequisites pass. label Jul 29, 2020

mergify bot merged commit 72ebafe into master Jul 29, 2020

mergify bot deleted the sahith/update-auth-cli branch July 29, 2020 22:33

amaury1093 mentioned this pull request Jul 30, 2020

Make signing types less confusing #6896

Closed

4 tasks

sahith-narahari mentioned this pull request Jul 30, 2020

Migrate remaining x/auth tx tests to proto #6898

Merged

9 tasks

clevinson mentioned this pull request Oct 2, 2020

x/auth: sign-batch command #6350

Merged

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update auth cli commands #6717

Update auth cli commands #6717

sahith-narahari commented Jul 14, 2020

codecov bot commented Jul 14, 2020 •

edited

Loading

lgtm-com bot commented Jul 15, 2020

aaronc commented Jul 29, 2020 •

edited

Loading

aaronc commented Jul 29, 2020

amaury1093 left a comment

aaronc commented Jul 29, 2020

alexanderbez Jul 29, 2020

lgtm-com bot commented Jul 29, 2020

lgtm-com bot commented Jul 29, 2020

aaronc commented Jul 29, 2020

Update auth cli commands #6717

Update auth cli commands #6717

Conversation

sahith-narahari commented Jul 14, 2020

Description

codecov bot commented Jul 14, 2020 • edited Loading

Codecov Report

lgtm-com bot commented Jul 15, 2020

aaronc commented Jul 29, 2020 • edited Loading

aaronc commented Jul 29, 2020

amaury1093 left a comment

Choose a reason for hiding this comment

aaronc commented Jul 29, 2020

alexanderbez Jul 29, 2020

Choose a reason for hiding this comment

lgtm-com bot commented Jul 29, 2020

lgtm-com bot commented Jul 29, 2020

aaronc commented Jul 29, 2020

codecov bot commented Jul 14, 2020 •

edited

Loading

aaronc commented Jul 29, 2020 •

edited

Loading