-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump identifier maximum to 64 characters #6812
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6812 +/- ##
==========================================
+ Coverage 61.17% 61.21% +0.04%
==========================================
Files 415 510 +95
Lines 25171 31531 +6360
==========================================
+ Hits 15399 19303 +3904
- Misses 8493 10733 +2240
- Partials 1279 1495 +216 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Thanks for upping this limit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK. Pending test fixes
…mos/cosmos-sdk into colin/update-identifier-restrictions
In the ibc-rs ICS24 implementation we're assuming a limit of 20 characters on any identifier. Not sure where this limit came from. Ideally, implementation updates should be downstream of cosmos/ics (canonical) updates. @cwgoes will there also be an update to ICS024? |
At the moment, the spec does not limit identifier length, because it isn't relevant to protocol safety - the 20 character limit was probably from a previous SDK version - but I can add this information to the spec if it would be helpful. |
Description
Increased identifier limit to 64 characters
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes