Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump identifier maximum to 64 characters #6812

Merged
merged 4 commits into from
Jul 22, 2020

Conversation

colin-axner
Copy link
Contributor

@colin-axner colin-axner commented Jul 22, 2020

Description

Increased identifier limit to 64 characters

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Jul 22, 2020

Codecov Report

Merging #6812 into master will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #6812      +/-   ##
==========================================
+ Coverage   61.17%   61.21%   +0.04%     
==========================================
  Files         415      510      +95     
  Lines       25171    31531    +6360     
==========================================
+ Hits        15399    19303    +3904     
- Misses       8493    10733    +2240     
- Partials     1279     1495     +216     

Copy link
Contributor

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Thanks for upping this limit

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@cwgoes cwgoes added the A:automerge Automatically merge PR once all prerequisites pass. label Jul 22, 2020
Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. Pending test fixes

@mergify mergify bot merged commit e9627ab into master Jul 22, 2020
@mergify mergify bot deleted the colin/update-identifier-restrictions branch July 22, 2020 10:20
@adizere
Copy link
Contributor

adizere commented Jul 22, 2020

In the ibc-rs ICS24 implementation we're assuming a limit of 20 characters on any identifier. Not sure where this limit came from. Ideally, implementation updates should be downstream of cosmos/ics (canonical) updates. @cwgoes will there also be an update to ICS024?

@cwgoes
Copy link
Contributor

cwgoes commented Jul 22, 2020

In the ibc-rs ICS24 implementation we're assuming a limit of 20 characters on any identifier. Not sure where this limit came from. Ideally, implementation updates should be downstream of cosmos/ics (canonical) updates. @cwgoes will there also be an update to ICS024?

At the moment, the spec does not limit identifier length, because it isn't relevant to protocol safety - the 20 character limit was probably from a previous SDK version - but I can add this information to the spec if it would be helpful.

cosmos/ibc#451

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants