Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add failing test-unit-proto CI job #6858

Merged
merged 2 commits into from
Jul 27, 2020
Merged

Conversation

aaronc
Copy link
Member

@aaronc aaronc commented Jul 27, 2020

ref: #6213

This adds a failing CI job for make test-unit-proto which runs unit tests against protobuf transactions.

This job is expected to fail until the critical path of #6213 is complete and is intended to provide developers working on #6213 feedback on progress towards completion.

Once make test-unit-proto succeeds, we will have a separate PR that flips the switch and makes this the default test configuration.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@aaronc aaronc changed the title Add test-unit-proto CI job Add failing test-unit-proto CI job Jul 27, 2020
@aaronc aaronc added the T: CI label Jul 27, 2020
@aaronc aaronc marked this pull request as ready for review July 27, 2020 14:31
@aaronc aaronc requested a review from tac0turtle July 27, 2020 15:58
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aaronc aaronc added the A:automerge Automatically merge PR once all prerequisites pass. label Jul 27, 2020
@mergify mergify bot merged commit 0201b94 into master Jul 27, 2020
@mergify mergify bot deleted the aaronc/6213-proto-ci-tests branch July 27, 2020 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. T: CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants