Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TxBuilder #6941

Merged
merged 3 commits into from
Aug 5, 2020
Merged

Remove TxBuilder #6941

merged 3 commits into from
Aug 5, 2020

Conversation

sahith-narahari
Copy link
Contributor

@sahith-narahari sahith-narahari commented Aug 4, 2020

Description

This PR removes TxBuilder of x/auth/types and it's usages
Ref : #6213


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@aaronc aaronc mentioned this pull request Aug 4, 2020
27 tasks
@alexanderbez
Copy link
Contributor

woohoo, I love code removal!

@codecov
Copy link

codecov bot commented Aug 5, 2020

Codecov Report

Merging #6941 into master will increase coverage by 0.25%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #6941      +/-   ##
==========================================
+ Coverage   61.80%   62.06%   +0.25%     
==========================================
  Files         521      519       -2     
  Lines       32156    31954     -202     
==========================================
- Hits        19875    19833      -42     
+ Misses      10670    10511     -159     
+ Partials     1611     1610       -1     

@alexanderbez alexanderbez added the A:automerge Automatically merge PR once all prerequisites pass. label Aug 5, 2020
Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@mergify mergify bot merged commit 4835cdc into master Aug 5, 2020
@mergify mergify bot deleted the sahith/remove-auth-txbldr branch August 5, 2020 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:x/auth
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants