Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/ibc: ClientState Any #6952

Closed
wants to merge 7 commits into from
Closed

x/ibc: ClientState Any #6952

wants to merge 7 commits into from

Conversation

fedekunze
Copy link
Collaborator

Description

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Aug 5, 2020

Codecov Report

Merging #6952 into master will decrease coverage by 2.52%.
The diff coverage is 42.10%.

@@            Coverage Diff             @@
##           master    #6952      +/-   ##
==========================================
- Coverage   62.10%   59.57%   -2.53%     
==========================================
  Files         519      368     -151     
  Lines       31990    21664   -10326     
==========================================
- Hits        19866    12907    -6959     
+ Misses      10513     7685    -2828     
+ Partials     1611     1072     -539     

@fedekunze fedekunze marked this pull request as ready for review August 6, 2020 09:27
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@fedekunze
Copy link
Collaborator Author

replaced by #6878

@fedekunze fedekunze closed this Aug 6, 2020
@fedekunze fedekunze deleted the fedekunze/fix-sim branch August 6, 2020 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants