Migrate Consensus State to being proto encoded/decoded in 02-client #6960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6960 +/- ##
==========================================
+ Coverage 62.10% 65.65% +3.55%
==========================================
Files 519 389 -130
Lines 31990 24168 -7822
==========================================
- Hits 19866 15867 -3999
+ Misses 10513 7061 -3452
+ Partials 1611 1240 -371 |
colin-axner
requested review from
aaronc,
alessio,
alexanderbez,
clevinson,
fedekunze and
jgimeno
as code owners
colin-axner
commented
Aug 6, 2020
| @@ -124,31 +124,31 @@ func QueryTendermintHeader(clientCtx client.Context) (ibctmtypes.Header, int64, | |||
|
|
|||
| // QueryNodeConsensusState takes a client context and returns the appropriate | |||
| // tendermint consensus state | |||
| func QueryNodeConsensusState(clientCtx client.Context) (ibctmtypes.ConsensusState, int64, error) { | |||
| func QueryNodeConsensusState(clientCtx client.Context) (*ibctmtypes.ConsensusState, int64, error) { | |||
There was a problem hiding this comment.
we can refactor querier to grpc in a followup
fedekunze
approved these changes
Aug 6, 2020
| @@ -124,31 +124,31 @@ func QueryTendermintHeader(clientCtx client.Context) (ibctmtypes.Header, int64, | |||
|
|
|||
| // QueryNodeConsensusState takes a client context and returns the appropriate | |||
| // tendermint consensus state | |||
| func QueryNodeConsensusState(clientCtx client.Context) (ibctmtypes.ConsensusState, int64, error) { | |||
| func QueryNodeConsensusState(clientCtx client.Context) (*ibctmtypes.ConsensusState, int64, error) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Proto encodes consensus state in
02-client. Removes amino from client keeper and connection keeper.ConsensusStateis now being passed around by reference. Genesis migration will ocurr in #6878ref: #6254
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes