-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
store: Remove Amino #6984
Merged
Merged
store: Remove Amino #6984
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
105c085
Update kv pair to proto
alexanderbez 3bf0f49
updates
alexanderbez e0b8dcc
fix LastCommitID
alexanderbez 98e0986
Merge branch 'master' into bez/store-amino-removal
alexanderbez d24f5d0
lint++
alexanderbez c11ab2a
Merge branch 'bez/store-amino-removal' of github.com:cosmos/cosmos-sd…
alexanderbez 6efbe7e
Merge branch 'master' into bez/store-amino-removal
alexanderbez 77a1fbc
Merge branch 'master' into bez/store-amino-removal
mergify[bot] e5ad3b1
Merge branch 'master' into bez/store-amino-removal
mergify[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
syntax = "proto3"; | ||
package cosmos.store; | ||
|
||
import "gogoproto/gogo.proto"; | ||
|
||
option go_package = "github.com/cosmos/cosmos-sdk/store/types"; | ||
|
||
// CommitInfo defines commit information used by the multi-store when committing | ||
// a version/height. | ||
message CommitInfo { | ||
int64 version = 1; | ||
repeated StoreInfo store_infos = 2 [(gogoproto.nullable) = false]; | ||
} | ||
|
||
// StoreInfo defines store-specific commit information. It contains a reference | ||
// between a store name and the commit ID. | ||
message StoreInfo { | ||
string name = 1; | ||
CommitID commit_id = 2 [(gogoproto.nullable) = false, (gogoproto.customname) = "CommitID"]; | ||
} | ||
|
||
// CommitID defines the committment information when a specific store is | ||
// committed. | ||
message CommitID { | ||
option (gogoproto.goproto_stringer) = false; | ||
|
||
int64 version = 1; | ||
bytes hash = 2; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rather this not be a top-level
cosmos
package. Isn't this really something internal to the SDK that clients or even people trying to re-implement the SDK in say rust would never use? We should have something likecosmos_sdk.internal
for stuff like this. Or am I wrong and is this an essential part of consensus state and the app hash?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that after #6905, we'll have a
cosmos.base
parent, so this can go ascosmos.base.store.v1beta1
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes @aaronc, it's used to compute the
AppHash
. I don't really care where this goes. If you have a preference on location, just let me know and I'll move it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's put it where @amaurymartiny suggested
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK