Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Event Indexing #7121

Merged
merged 8 commits into from
Aug 20, 2020
Merged

Support Event Indexing #7121

merged 8 commits into from
Aug 20, 2020

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Aug 20, 2020

Description

Add a new index_events config/flag to support application-driven event filtering as this will be removed in Tendermint 0.34.

/cc @marbar3778

closes: #6277


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Aug 20, 2020

Codecov Report

Merging #7121 into master will increase coverage by 0.00%.
The diff coverage is 67.85%.

@@           Coverage Diff           @@
##           master    #7121   +/-   ##
=======================================
  Coverage   54.21%   54.22%           
=======================================
  Files         547      547           
  Lines       37538    37564   +26     
=======================================
+ Hits        20351    20368   +17     
- Misses      15508    15517    +9     
  Partials     1679     1679           

Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Pending changelog entry

@alexanderbez alexanderbez merged commit f0d2c86 into master Aug 20, 2020
@alexanderbez alexanderbez deleted the bez/6277-tx-index-update branch August 20, 2020 16:19
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

txs: indexing at runtime
3 participants