Fix AcknowledgePacket and AcknowledgementExecuted bug + update testing pkg #7170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colin-axner
requested review from
aaronc,
alessio and
alexanderbez
as code owners
colin-axner
commented
Aug 26, 2020
| // PacketExecuted receives a packet through the channel keeper on the source chain and updates the | ||
| // counterparty client for the source chain. | ||
| func (coord *Coordinator) PacketExecuted( | ||
| // RecvPacket receives a channel packet on the counterparty chain and updates |
There was a problem hiding this comment.
I reordered some code, the diffs don't reflect it well
Codecov Report
@@ Coverage Diff @@
## master #7170 +/- ##
==========================================
- Coverage 55.60% 54.50% -1.10%
==========================================
Files 457 566 +109
Lines 27440 38752 +11312
==========================================
+ Hits 15257 21122 +5865
- Misses 11083 15900 +4817
- Partials 1100 1730 +630 |
fedekunze
approved these changes
Aug 26, 2020
colin-axner
added
the
A:automerge
|
Thanks for adding the modifications to ibc testing package upstream as well. Very much appreciated 💐 |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upstreams changes made on this pr. chain-id is no included in connection ids and channel ids for testing so chainA and chainB won't have identical channel IDs. Fixes the bug in the below issue as well.
I tried adding random strings as well, but it gets a bit complex because sometimes you want to refer to a channel that hasn't been created yet and trying to refer to this channel with randomness causes non-trivial overhead.
closes: #7156
ref: #6509
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes