Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sawgger gen output dir #7374

Merged
merged 5 commits into from
Sep 23, 2020
Merged

Fix sawgger gen output dir #7374

merged 5 commits into from
Sep 23, 2020

Conversation

anilcse
Copy link
Collaborator

@anilcse anilcse commented Sep 23, 2020 •
edited
Loading

Description

ref #7246 (comment)

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@anilcse anilcse mentioned this pull request Sep 23, 2020
Merged
9 tasks
@anilcse anilcse marked this pull request as ready for review September 23, 2020 12:29
@anilcse anilcse added T:Docs Changes and features related to documentation. C: gRPC Issues and PRs related to the gRPC service and HTTP gateway. A:automerge Automatically merge PR once all prerequisites pass. labels Sep 23, 2020
amaury1093
amaury1093 reviewed Sep 23, 2020
View reviewed changes
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, after Alessio's suggestion

@mergify mergify bot merged commit a722933 into master Sep 23, 2020
@mergify mergify bot deleted the anil/tiny_grpc_gateway_fixes branch September 23, 2020 14:16
secret2830 pushed a commit to bianjieai/cosmos-sdk that referenced this pull request Sep 27, 2020
@anilcse
Fix sawgger gen output dir (cosmos#7374)
3627bc6 
* Fix sawgger gen output dir

* Fix lint

* Update make clean

Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alessio alessio alessio approved these changes

@amaury1093 amaury1093 amaury1093 approved these changes

@aaronc aaronc Awaiting requested review from aaronc

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

@atheeshp atheeshp Awaiting requested review from atheeshp

@clevinson clevinson Awaiting requested review from clevinson

@fedekunze fedekunze Awaiting requested review from fedekunze

Assignees
No one assigned
Labels
A:automerge Automatically merge PR once all prerequisites pass. C: gRPC Issues and PRs related to the gRPC service and HTTP gateway. T:Docs Changes and features related to documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anilcse @alessio @amaury1093