-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support denoms custom validation #7450
Merged
okwme
merged 5 commits into
launchpad/backports
from
billy/6744-launchpad-custom-validation
Oct 7, 2020
+52
−7
Merged
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
c3cc14c
make coin evaluation into functions instead of static
okwme 5b6cff4
reset default regex
okwme 726d57a
Update CHANGELOG.md
okwme a74a519
Update CHANGELOG.md
okwme 85d4291
Merge branch 'launchpad/backports' into billy/6744-launchpad-custom-v…
okwme File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -70,6 +70,31 @@ func TestCoinIsValid(t *testing.T) { | |
} | ||
} | ||
|
||
func TestCustomValidation(t *testing.T) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This part I get There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
||
|
||
newDnmRegex := `[\x{1F600}-\x{1F6FF}]` | ||
CoinDenomRegex = func() string { | ||
return newDnmRegex | ||
} | ||
|
||
cases := []struct { | ||
coin Coin | ||
expectPass bool | ||
}{ | ||
{Coin{"🙂", NewInt(1)}, true}, | ||
{Coin{"😃", NewInt(1)}, true}, | ||
{Coin{"😄", NewInt(1)}, true}, | ||
{Coin{"🌶", NewInt(1)}, false}, // outside the unicode range listed above | ||
{Coin{"asdf", NewInt(1)}, false}, | ||
{Coin{"", NewInt(1)}, false}, | ||
} | ||
|
||
for i, tc := range cases { | ||
require.Equal(t, tc.expectPass, tc.coin.IsValid(), "unexpected result for IsValid, tc #%d", i) | ||
} | ||
CoinDenomRegex = DefaultCoinDenomRegex | ||
} | ||
|
||
func TestAddCoin(t *testing.T) { | ||
cases := []struct { | ||
inputOne Coin | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And so if I write the global
CoinDenomRegex
it will let me override all these checks done inside of Coin.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exactly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/interchainberlin/pooltoy/blob/master/cmd/pooltoyd/main.go#L37