-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
keyring-dir flag #7485
Merged
Merged
keyring-dir flag #7485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7485 +/- ##
==========================================
- Coverage 56.01% 52.86% -3.16%
==========================================
Files 591 437 -154
Lines 37188 27345 -9843
==========================================
- Hits 20831 14456 -6375
+ Misses 14233 11405 -2828
+ Partials 2124 1484 -640 |
Need to update some tests. Will try to get to this asap @michaelfig |
This PR currently doesn't work for me:
but:
|
Works for me! |
alexanderbez
added
A:automerge
Automatically merge PR once all prerequisites pass.
C:Keys
Keybase, KMS and HSMs
labels
Oct 8, 2020
alessio
approved these changes
Oct 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Operators may wish to have their Keyring & client material reside in a different directory than the directory dictated by the
--home
flag. Introduce a new--keyring-dir
flag.replaces: #7436
/cc @michaelfig
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes