simapp InitChainer: use json instead of tmjson #7523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7523 +/- ##
=======================================
Coverage 61.46% 61.46%
=======================================
Files 659 659
Lines 37932 37932
=======================================
Hits 23316 23316
Misses 12172 12172
Partials 2444 2444
|
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Still relevant, i'll try to add this missing test. |
|
Any progress here? Can we close the or and open an issue. We can keep the branch around but let's clean up the pull request section |
amaury1093
requested review from
aaronc,
alessio and
alexanderbez
as code owners
amaury1093
added
A:automerge
|
ready for review will do the test in another PR. |
tac0turtle
approved these changes
Feb 24, 2021
|
Yes. btw |
amaury1093
requested review from
aleem1314,
anilcse,
atheeshp,
blushi and
robert-zaremba
anilcse
approved these changes
Feb 24, 2021
larry0x
pushed a commit
to larry0x/cosmos-sdk
that referenced
this pull request
May 22, 2023
* simapp InitChainer: use json instead of tmjson * First run for test * Revert export_test Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ref: #7514 (comment)
GenesisState is a
map[string]json.RawMessage. So a json.Unmarshal is enough. The actual decoding of theseRawMessageusing appCodec is done inInitGenesis(2 lines below).TODO:
I will create a test to: 1/ export a genesis file and 2/ run simapp again with the exported file.Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes