add secp as option for validator keys

[tac0turtle]

Description

add secp as an option for validator keys

closes: #7529

Tracking:

• cosmos-sdk/x/staking/types/validator.go

  Line 460 in da990bf

  func (v Validator) GetConsPubKey() (crypto.PubKey, error) {

• cosmos-sdk/simapp/test_helpers.go

  Line 99 in 1dd1742

  pk, err := ed25519.FromTmEd25519(val.PubKey)

---

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

• Targeted PR against correct branch (see CONTRIBUTING.md)
• Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
• Code follows the module structure standards.
• Wrote unit and integration tests
• Updated relevant documentation (docs/) or specification (x/<module>/spec/)
• Added relevant godoc comments.
• Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
• Re-reviewed Files changed in the Github PR explorer
• Review Codecov Report in the comment section below once CI passes

[codecov]

Codecov Report

Merging #7604 into master will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #7604      +/-   ##
==========================================
- Coverage   54.21%   54.19%   -0.02%     
==========================================
  Files         611      611              
  Lines       38464    38475      +11     
==========================================
  Hits        20852    20852              
- Misses      15503    15514      +11     
  Partials     2109     2109              

[robert-zaremba]

Hey, I've added a Tracking section to list places which will need to be updated.

[tac0turtle]

Hey, I've added a Tracking section to list places which will need to be updated.

Thank you, they will need to be updated after your PR is merged? the above two places may not need any updating is what I observed.

[tac0turtle]

the issue I am running into now is that the key requested from the DB is inserted with a different encoding. Not sure how to go about this but diving deeper.

[tac0turtle]

@amaurymartiny did you try creating your own pubkeyFromProto method that handles tendermint proto keys? I would think this would rid yourself of handling tendermint keys in the sdk?

[tac0turtle]

closing in favor of #7635