Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ibc change connection version string to proto #7680

Merged

Conversation

colin-axner
Copy link
Contributor

@colin-axner colin-axner commented Oct 26, 2020

Description

various fixes added, not everything is fixed yet. To be merged into the existing pr for this change, not master

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Oct 26, 2020

Codecov Report

❗ No coverage uploaded for pull request base (fedekunze/ibc-version-any@e543a70). Click here to learn what that means.
The diff coverage is n/a.

@@                     Coverage Diff                      @@
##             fedekunze/ibc-version-any    #7680   +/-   ##
============================================================
  Coverage                             ?   54.12%           
============================================================
  Files                                ?      611           
  Lines                                ?    38526           
  Branches                             ?        0           
============================================================
  Hits                                 ?    20851           
  Misses                               ?    15548           
  Partials                             ?     2127           

@colin-axner colin-axner merged commit 55e2fec into fedekunze/ibc-version-any Oct 27, 2020
@colin-axner colin-axner deleted the colin/connection-version-change branch October 27, 2020 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant