Robert/initgensis profiling #7741
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robert-zaremba
requested review from
aaronc,
alessio and
alexanderbez
as code owners
robert-zaremba
added
backport/0.40.x (Stargate)
C:genesis
zmanian
reviewed
Oct 30, 2020
simapp/app.go
Outdated
| @@ -324,7 +324,7 @@ func NewSimApp( | |||
| vesting.NewAppModule(app.AccountKeeper, app.BankKeeper), | |||
| bank.NewAppModule(appCodec, app.BankKeeper, app.AccountKeeper), | |||
| capability.NewAppModule(appCodec, *app.CapabilityKeeper), | |||
| crisis.NewAppModule(&app.CrisisKeeper), | |||
| crisis.NewAppModule(&app.CrisisKeeper, true), | |||
There was a problem hiding this comment.
Ideally we need to be check if crisis invariants pass based on flag passes to start and not a compile time Boolean
There was a problem hiding this comment.
OK, no problem. I asked about it on the issue page. Here, this is a simapp, not gaia.
|
I'm closing this PR in favor of #7764 This branch can be used if someone will like to play with the release branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimizing InitGenezis
Description
TODO:
closes: #7682
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes