Bech32 PubKey: use protobuf in slashing keeper #7979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robert-zaremba
requested review from
aaronc,
alessio and
alexanderbez
as code owners
Codecov Report
@@ Coverage Diff @@
## master #7979 +/- ##
=======================================
Coverage 61.56% 61.57%
=======================================
Files 601 601
Lines 34446 34443 -3
=======================================
- Hits 21208 21207 -1
+ Misses 11054 11053 -1
+ Partials 2184 2183 -1 |
alessio
approved these changes
Nov 19, 2020
amaury1093
reviewed
Nov 19, 2020
amaury1093
added
the
T: State Machine Breaking
robert-zaremba
force-pushed
the
robert/bech32-pubkey-slashing
branch
from
aebc3c9 to
fdac398
Compare
|
Updated the changelog |
alexanderbez
approved these changes
Nov 19, 2020
|
@alexanderbez I don't think so, as Robert wrote:
|
amaury1093
approved these changes
Nov 19, 2020
|
Got it 👍 (note, on a live upgrade I believe it would) |
robert-zaremba
removed
the
T: State Machine Breaking
sahith-narahari
approved these changes
Nov 19, 2020
robert-zaremba
added
the
A:automerge
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
x/slashingkeeper was not migrated to use protobuf serialization for pub keys.This change breaks the state machine and thus requires a migration for update. That being said we don't need to write new migration, because this keeper data is not a part genesis object (it's generated through processing other genesis messages).
Related to: #7447
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes