Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/v0.40.1 #8366

Closed
wants to merge 10 commits into from
Closed

Release/v0.40.1 #8366

wants to merge 10 commits into from

Conversation

robert-zaremba
Copy link
Collaborator

Description

Cherry pick all fixes from master into release/40.x

  • Changelog update

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

aleem1314 and others added 10 commits January 18, 2021 23:38
* fix cli queries

* fix codec issue

* revert cli

Co-authored-by: SaReN <sahithnarahari@gmail.com>
)

* build(deps): bump github.com/armon/go-metrics from 0.3.5 to 0.3.6

Bumps [github.com/armon/go-metrics](https://github.com/armon/go-metrics) from 0.3.5 to 0.3.6.
- [Release notes](https://github.com/armon/go-metrics/releases)
- [Commits](hashicorp/go-metrics@v0.3.5...v0.3.6)

Signed-off-by: dependabot[bot] <support@github.com>

* go.sum

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Federico Kunze <federico.kunze94@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Bumps [github.com/gogo/protobuf](https://github.com/gogo/protobuf) from 1.3.1 to 1.3.2.
- [Release notes](https://github.com/gogo/protobuf/releases)
- [Commits](gogo/protobuf@v1.3.1...v1.3.2)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* fix signature only

* add test, changelog

* update test

* Update CHANGELOG.md

* address suggestions

Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* Update gogo proto deps with v1.3.2 security fixes

* Regenerate proto files
* fix-ibc-client

* add changelog
* fix proto generation

* merge grpc_gateway into gocosmos_out

* change env variable names
* fix: wrappedError.Is

Is method should return true when used on 2 same errors.

* Changelog update

Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@robert-zaremba
Copy link
Collaborator Author

NOTE: before merge, let's update the policy and not squash commits (except the last one for Changelog update). These are commits from master, so no need to squash them into a single commit.

@robert-zaremba robert-zaremba changed the base branch from master to release/v0.40.x January 18, 2021 22:50
Comment on lines +37 to +38
## [Unreleased]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## [Unreleased]

I think we can remove these 2 lines on this branch (keep it on master), so that tags/release branches have nice changelogs.

@@ -34,6 +34,21 @@ Ref: https://keepachangelog.com/en/1.0.0/

Copy link
Contributor

@amaury1093 amaury1093 Jan 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have a question about the three following PRs, which seem like bug fixes to me, and should go in 0.40.1:

For the 2 latter, @alessio do you think they should go into the patch release?

Copy link
Contributor

@colin-axner colin-axner Jan 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#8359 needs to be backported. The relayer won't work without it. I forgot to add a changelog entry, I guess I can open a new pr to master with the entry and then that should be cherry picked as well? Change log updated in #8371

@alessio alessio closed this Jan 19, 2021
@alessio alessio deleted the release/v0.40.1 branch January 19, 2021 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants