Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix legacy rest api #8434

Merged
merged 14 commits into from
Feb 26, 2021
Merged

Fix legacy rest api #8434

merged 14 commits into from
Feb 26, 2021

Conversation

SegueII
Copy link
Contributor

@SegueII SegueII commented Jan 26, 2021 •
edited
Loading

/supply/total => /bank/total
/supply/total/denom => /bank/total/denom

@SegueII SegueII changed the title Fix legacy rest api (/supply/total=>/bank/total) Fix legacy rest api Jan 26, 2021
@amaury1093
Copy link
Contributor

Thanks @SegueII, could you fix the conflict?

amaury1093
amaury1093 approved these changes Jan 29, 2021
View reviewed changes
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

Btw, did you make this change manually, or did you run a command?

@SegueII
Copy link
Contributor Author

SegueII commented Jan 29, 2021 •
edited
Loading

I changed it manually, but I did not run make commands to update statik.go and swagger.yaml

anilcse
anilcse reviewed Feb 4, 2021
View reviewed changes
Copy link
Collaborator

@anilcse anilcse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update swagger docs as well? make proto-swagger-gen

@amaury1093 amaury1093 added A:automerge Automatically merge PR once all prerequisites pass. T:Docs Changes and features related to documentation. REST labels Feb 22, 2021
@amaury1093
Copy link
Contributor

@SegueII Could you fix conflicts?

@tac0turtle
Copy link
Member

@SegueII please update your branch with master. That way the bot will be able to merge this

@tac0turtle tac0turtle merged commit 92bc290 into cosmos:master Feb 26, 2021
@SegueII SegueII deleted the swagger-fix branch March 1, 2021 10:05
SegueII added a commit to irisnet/cosmos-sdk that referenced this pull request Mar 2, 2021
@SegueII
Fix legacy rest api (cosmos#8434)
7a3e1a8
SegueII added a commit to irisnet/cosmos-sdk that referenced this pull request Mar 4, 2021
@SegueII
Fix legacy rest api (cosmos#8434)
d9d0fd1
@0xHansLee 0xHansLee mentioned this pull request Jun 22, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amaury1093 amaury1093 amaury1093 approved these changes

@anilcse anilcse anilcse approved these changes

@aaronc aaronc Awaiting requested review from aaronc

@alessio alessio Awaiting requested review from alessio

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

Assignees
No one assigned
Labels
A:automerge Automatically merge PR once all prerequisites pass. T:Docs Changes and features related to documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SegueII @amaury1093 @tac0turtle @anilcse