Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/authz specs #8499

Merged
merged 21 commits into from
Feb 11, 2021
Merged

x/authz specs #8499

merged 21 commits into from
Feb 11, 2021

Conversation

aleem1314
Copy link
Contributor

Description

closes: #8438


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@aleem1314 aleem1314 marked this pull request as ready for review February 3, 2021 14:19
@aleem1314 aleem1314 changed the title x/authz spec x/authz specs Feb 4, 2021
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, couple of small comments

x/authz/spec/01_concepts.md Outdated Show resolved Hide resolved
x/authz/spec/01_concepts.md Outdated Show resolved Hide resolved
x/authz/spec/02_state.md Outdated Show resolved Hide resolved
x/authz/spec/03_messages.md Outdated Show resolved Hide resolved
x/authz/spec/README.md Outdated Show resolved Hide resolved
@amaury1093 amaury1093 added T:Docs Changes and features related to documentation. C:x/authz labels Feb 4, 2021
x/README.md Outdated Show resolved Hide resolved
aleem1314 and others added 5 commits February 4, 2021 16:41
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: Amaury <amaury.martiny@protonmail.com>
Co-authored-by: Amaury <amaury.martiny@protonmail.com>
Co-authored-by: Amaury <amaury.martiny@protonmail.com>
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

x/authz/spec/01_concepts.md Outdated Show resolved Hide resolved
x/authz/spec/02_state.md Outdated Show resolved Hide resolved
aleem1314 and others added 2 commits February 5, 2021 19:25
Co-authored-by: Amaury <amaury.martiny@protonmail.com>
Co-authored-by: Amaury <amaury.martiny@protonmail.com>
@clevinson clevinson self-assigned this Feb 10, 2021
Copy link
Contributor

@clevinson clevinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments about ADR linking, otherwise lgtm. Thanks @aleem1314 !

x/authz/spec/04_events.md Outdated Show resolved Hide resolved
x/authz/spec/04_events.md Outdated Show resolved Hide resolved
x/authz/spec/01_concepts.md Outdated Show resolved Hide resolved
x/authz/spec/README.md Outdated Show resolved Hide resolved
aleem1314 and others added 4 commits February 11, 2021 11:59
Co-authored-by: Cory <cjlevinson@gmail.com>
Co-authored-by: Cory <cjlevinson@gmail.com>
Co-authored-by: Cory <cjlevinson@gmail.com>
Co-authored-by: Cory <cjlevinson@gmail.com>
Copy link
Contributor

@clevinson clevinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 🎉

@clevinson clevinson added the A:automerge Automatically merge PR once all prerequisites pass. label Feb 11, 2021
@mergify mergify bot merged commit 2154815 into master Feb 11, 2021
@mergify mergify bot deleted the aleem/8438-authz-spec branch February 11, 2021 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:x/authz T:Docs Changes and features related to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write SPEC for x/authz
4 participants