Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snapshots: document use of ioutil.TempDir() #8508

Merged
merged 1 commit into from
Feb 4, 2021

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Feb 4, 2021

Document with inline comments the changes introduced
in #8475.

Run make format.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

Document with inline comments the changes introduced
in #8475.

Run make format.
@alessio alessio force-pushed the alessio/document-exeptional-use-of-tempdir branch from 026d0c3 to 59284e3 Compare February 4, 2021 08:34
@amaury1093 amaury1093 added the A:automerge Automatically merge PR once all prerequisites pass. label Feb 4, 2021
@mergify mergify bot merged commit 2e04f27 into master Feb 4, 2021
@mergify mergify bot deleted the alessio/document-exeptional-use-of-tempdir branch February 4, 2021 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants