Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fuzz: add types.ParseCoin #8513

Merged
merged 1 commit into from
Mar 22, 2021
Merged

fuzz: add types.ParseCoin #8513

merged 1 commit into from
Mar 22, 2021

Conversation

cuonglm
Copy link
Contributor

@cuonglm cuonglm commented Feb 4, 2021

Description

Add fuzzing for types.ParseCoin.

Updates #7921

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@cuonglm
Copy link
Contributor Author

cuonglm commented Feb 4, 2021

cc @odeke-em

Copy link
Collaborator

@odeke-em odeke-em left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @cuonglm. For an introduction, @cuonglm works with me at @orijtech and will also be sending changes.

Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a basic README would be useful.

I can see the corpus/*.seed files being used, but have no idea why the other files are committed. Also, would like to know who to run the fuzzer.

@alessio
Copy link
Contributor

alessio commented Feb 12, 2021

Great stuff. Can we move the fuzzy test data into testutil please?

I agree with @amaurymartiny too as I'd love to integrate the fuzzer in our buildsystem.

@cuonglm
Copy link
Contributor Author

cuonglm commented Feb 16, 2021

Go fuzz can be part of go1.17 https://go.googlesource.com/proposal/+/master/design/draft-fuzzing.md

In the meantime, I don't know what's the best way to do this, other than following go-fuzz readme. Any idea @odeke-em ?

@tac0turtle
Copy link
Member

can you add a quick README file here. I realize we can go to go-fuzz to see how to run these but lets get some docs in here to avoid the extra step. It can also be a copy with minor adjustments of what is in the go-fuzz repo.

@tac0turtle
Copy link
Member

@cuonglm could you please add a short readme on how to run these tests?

@cuonglm
Copy link
Contributor Author

cuonglm commented Mar 22, 2021

@cuonglm could you please add a short readme on how to run these tests?

Sure, to be clear, you mean add readme for how to run this with go-fuzz?

@tac0turtle
Copy link
Member

Sure, to be clear, you mean add readme for how to run this with go-fuzz?

Yes, how to run them, what dependencies are required. This avoids the dev from going elsewhere to read docs.

@tac0turtle
Copy link
Member

after linting is fixed we can merge this

@cuonglm
Copy link
Contributor Author

cuonglm commented Mar 22, 2021

after linting is fixed we can merge this

It seems weird, since when the golangci-lint error seems not related to this change. Maybe we can just merge this and fix in the fuzz-packages branch? cc @odeke-em

@tac0turtle tac0turtle merged commit bdec2b2 into cosmos:fuzz-packages Mar 22, 2021
odeke-em pushed a commit that referenced this pull request Apr 14, 2021
odeke-em pushed a commit that referenced this pull request Apr 22, 2021
odeke-em pushed a commit that referenced this pull request Apr 22, 2021
odeke-em pushed a commit that referenced this pull request Apr 24, 2021
odeke-em pushed a commit that referenced this pull request Jul 22, 2021
odeke-em pushed a commit that referenced this pull request Jul 22, 2021
odeke-em pushed a commit that referenced this pull request Jul 28, 2021
odeke-em pushed a commit that referenced this pull request Jul 28, 2021
odeke-em pushed a commit that referenced this pull request Mar 30, 2022
odeke-em pushed a commit that referenced this pull request Mar 30, 2022
elias-orijtech pushed a commit to elias-orijtech/cosmos-sdk that referenced this pull request Apr 11, 2022
elias-orijtech pushed a commit to elias-orijtech/cosmos-sdk that referenced this pull request Apr 11, 2022
elias-orijtech pushed a commit to elias-orijtech/cosmos-sdk that referenced this pull request May 6, 2022
elias-orijtech pushed a commit to elias-orijtech/cosmos-sdk that referenced this pull request May 6, 2022
odeke-em pushed a commit that referenced this pull request Jun 4, 2022
odeke-em pushed a commit that referenced this pull request Jun 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants