-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add failing address to multisig validation #8518
Conversation
x/auth/client/cli/tx_multisign.go
Outdated
@@ -125,7 +125,7 @@ func makeMultiSignCmd() func(cmd *cobra.Command, args []string) (err error) { | |||
for _, sig := range sigs { | |||
err = signing.VerifySignature(sig.PubKey, signingData, sig.Data, txCfg.SignModeHandler(), txBuilder.GetTx()) | |||
if err != nil { | |||
return fmt.Errorf("couldn't verify signature: %w", err) | |||
return fmt.Errorf("couldn't verify signature for address %s", sig.PubKey.Address()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addr, _ := sdktypes.AccAddressFromHex(stdSig.PubKey.Address().String())
return fmt.Errorf("couldn't verify signature for address %s", addr)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs an import added too
sdktypes "github.com/cosmos/cosmos-sdk/types"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
danke, got both.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, would be cool to have a test for this
@@ -125,7 +125,8 @@ func makeMultiSignCmd() func(cmd *cobra.Command, args []string) (err error) { | |||
for _, sig := range sigs { | |||
err = signing.VerifySignature(sig.PubKey, signingData, sig.Data, txCfg.SignModeHandler(), txBuilder.GetTx()) | |||
if err != nil { | |||
return fmt.Errorf("couldn't verify signature: %w", err) | |||
addr, _ := sdk.AccAddressFromHex(sig.PubKey.Address().String()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit you can drop the .String()
as the %s
formatter will automatically do this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, would be cool to have a test for this
Actually there is one test, and it's failing now. OK to merge once test passes
…sdk into jack/multisig-index
This PR helps users of multisig wallets debug signature issues. cc @zmanian for the hat tip