-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for permanent locked vesting accounts #8520
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
5fdcff4
add basics for permanent locked vesting account support
clevinson 148f6c2
remove sdk.Msg support for PermanentLockedVestingAccount
clevinson 93d1ba9
add tests for PermanentLockedVestingAccount
clevinson 697ee2f
remove unecessary tests
clevinson 5f96bf0
drop unecessary create vesting acct msgs
clevinson efbfd1d
Merge branch 'master' into clevinson/permanent-vesting-account
clevinson c88a1da
Update x/auth/vesting/types/vesting_account.go
amaury1093 987ca05
Update x/auth/vesting/types/vesting_account.go
amaury1093 162a1d6
Update x/auth/vesting/types/vesting_account.go
amaury1093 06216a3
Update x/auth/vesting/types/vesting_account_test.go
amaury1093 045f6a5
Merge branch 'master' of ssh://github.com/cosmos/cosmos-sdk into clev…
amaury1093 670df86
Merge branch 'clevinson/permanent-vesting-account' of ssh://github.co…
amaury1093 a2443f4
Review changes
amaury1093 d8f6930
Factorize init function
amaury1093 072a6d0
Factorize more
amaury1093 7276244
Comments
amaury1093 a0d197a
Merge branch 'master' into clevinson/permanent-vesting-account
amaury1093 d202bd3
Fix build after rename
amaury1093 1755c6f
Merge branch 'master' into clevinson/permanent-vesting-account
amaury1093 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,6 +5,5 @@ import ( | |
) | ||
|
||
var ( | ||
app = simapp.Setup(false) | ||
appCodec = simapp.MakeTestEncodingConfig().Marshaler | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. unused var |
||
app = simapp.Setup(false) | ||
) |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't need to repeat type name in the attribute name. How about
base_account
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed
PermanentLockedVestingAccount
toPermanentLockedAccount
, but I disagree with this one:BaseVestingAccount
has a fieldBaseAccount
. I dont want to dopermanentAccount.BaseAccount.BaseAccount.*