Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup pagination tests #8565

Merged
merged 2 commits into from
Feb 11, 2021
Merged

Cleanup pagination tests #8565

merged 2 commits into from
Feb 11, 2021

Conversation

sahith-narahari
Copy link
Contributor

Description

closes: #XXXX

cc\ @anilcse


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@sahith-narahari sahith-narahari added the Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. label Feb 11, 2021
@sahith-narahari sahith-narahari marked this pull request as ready for review February 11, 2021 04:57
@alessio alessio merged commit bddbc13 into master Feb 11, 2021
@alessio alessio deleted the sahith/fix-page-tests branch February 11, 2021 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants