Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pagination to GetValidatorSetByHeight response #8567

Merged
merged 4 commits into from
Feb 15, 2021

Conversation

aleem1314
Copy link
Contributor

Description

closes: #8560


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Feb 11, 2021

Codecov Report

Merging #8567 (5a8028b) into master (e306e5b) will increase coverage by 0.00%.
The diff coverage is 44.44%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8567   +/-   ##
=======================================
  Coverage   61.43%   61.43%           
=======================================
  Files         656      656           
  Lines       37533    37535    +2     
=======================================
+ Hits        23059    23061    +2     
- Misses      12065    12067    +2     
+ Partials     2409     2407    -2     
Impacted Files Coverage Δ
client/rpc/validators.go 0.00% <0.00%> (ø)
client/grpc/tmservice/service.go 68.42% <100.00%> (+2.96%) ⬆️
client/grpc_query.go 28.26% <0.00%> (-0.91%) ⬇️
baseapp/grpcserver.go 2.56% <0.00%> (-0.14%) ⬇️
server/grpc/server.go 62.50% <0.00%> (ø)
baseapp/grpcrouter.go 86.04% <0.00%> (+6.04%) ⬆️

Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, could you add a test?

@aleem1314 aleem1314 requested a review from amaury1093 February 15, 2021 06:33
@amaury1093 amaury1093 added A:automerge Automatically merge PR once all prerequisites pass. C: gRPC Issues and PRs related to the gRPC service and HTTP gateway. labels Feb 15, 2021
@mergify mergify bot merged commit d162b29 into master Feb 15, 2021
@mergify mergify bot deleted the aleem/8560-tm-grpc-pagination branch February 15, 2021 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C: gRPC Issues and PRs related to the gRPC service and HTTP gateway.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pagination not available in gRPC base.tendermint.Service. GetValidatorSetByHeight
3 participants