Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tm version to makefile #8689

Merged
merged 2 commits into from
Feb 24, 2021
Merged

add tm version to makefile #8689

merged 2 commits into from
Feb 24, 2021

Conversation

tac0turtle
Copy link
Member

Description

add tm version to make file

closes: #7963


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@tac0turtle tac0turtle self-assigned this Feb 24, 2021
@tac0turtle tac0turtle added the A:automerge Automatically merge PR once all prerequisites pass. label Feb 24, 2021
Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tac0turtle tac0turtle merged commit 2c18d8a into master Feb 24, 2021
@tac0turtle tac0turtle deleted the 7963-add-tmversion branch February 24, 2021 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression rc2 -> rc3: simapp is missing the Tendermint version in RPC API
2 participants