crypto/keyring: fix offline keys migration #8738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix `keys migrate` command (#8703) crypto/keyring: reinstate the InfoImporter interface InfoImporter is implemented by those Keyring implementations that support import of Info objects. Co-authored-by: Alessio Treglia <alessio@tendermint.com> Co-authored-by: Jonathan Gimeno <jgimeno@gmail.com> Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
alessio
requested review from
gsora,
robert-zaremba,
amaury1093,
ebuchman,
jgimeno,
sahith-narahari and
fdymylja
tac0turtle
approved these changes
Mar 1, 2021
added 2 commits
March 1, 2021 19:32
Avoid namespace clash with the InfoImporter interface that already exists in the v0.41 release series.
This reverts commit 38e1349.
Codecov Report
@@ Coverage Diff @@
## release/v0.41.x #8738 +/- ##
===================================================
+ Coverage 61.93% 61.95% +0.01%
===================================================
Files 612 612
Lines 35412 35417 +5
===================================================
+ Hits 21932 21942 +10
+ Misses 11168 11155 -13
- Partials 2312 2320 +8
|
sahith-narahari
approved these changes
Mar 2, 2021
fdymylja
approved these changes
Mar 2, 2021
amaury1093
approved these changes
Mar 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From: #8639
Fix
keys migratecommand (closes: #8703)crypto/keyring: reinstate the InfoImporter interface
LegacyInfoImporter is implemented by those Keyring implementations
that support import of Info objects.
Co-authored-by: Alessio Treglia alessio@tendermint.com
Co-authored-by: Jonathan Gimeno jgimeno@gmail.com
Co-authored-by: Amaury 1293565+amaurym@users.noreply.github.com
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes