Enable secp256r1 #8786
Merged
Enable secp256r1 #8786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robert-zaremba
commented
Mar 4, 2021
robert-zaremba
commented
Mar 4, 2021
| // implementation wold be 20x slower. | ||
| func (p Params) SigVerifyCostSecp256r1() uint64 { | ||
| return p.SigVerifyCostSecp256k1 * 12 / 10 // 120% | ||
| } |
There was a problem hiding this comment.
Let's discuss the fee adjustment in #8515
alessio
approved these changes
Mar 4, 2021
robert-zaremba
added
the
A:automerge
Codecov Report
@@ Coverage Diff @@
## master #8786 +/- ##
=======================================
Coverage 59.37% 59.37%
=======================================
Files 563 563
Lines 31251 31255 +4
=======================================
+ Hits 18554 18557 +3
- Misses 10543 10544 +1
Partials 2154 2154
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enables secp256r1 in SDK!
closes: #8515
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes