-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add orderBy parameter to TxsByEvents #8815
Merged
Merged
Changes from 14 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
518d51e
add orderBy parameter to grpc query
aleem1314 4462b29
add orderby parameter
aleem1314 9bb4c17
Merge branch 'master' into aleem/8686-txevents-orderby
aleem1314 e48182c
Merge branch 'master' into aleem/8686-txevents-orderby
aleem1314 0dcf941
Merge branch 'master' into aleem/8686-txevents-orderby
aleem1314 95fab78
Merge branch 'master' into aleem/8686-txevents-orderby
aleem1314 ca11fa3
Merge branch 'master' into aleem/8686-txevents-orderby
3f1f12a
change orderBy param to enum
aleem1314 6daa020
Merge branch 'master' into aleem/8686-txevents-orderby
aleem1314 8dfd45b
lint
aleem1314 8880348
proto lint
aleem1314 e8cc788
Merge branch 'master' into aleem/8686-txevents-orderby
jgimeno f2723ff
add changelog
aleem1314 7327892
Merge branch 'aleem/8686-txevents-orderby' of https://github.com/cosm…
aleem1314 d384dd1
Update x/auth/tx/service.go
aleem1314 dd424ed
Merge branch 'master' into aleem/8686-txevents-orderby
aleem1314 47e3db0
Merge branch 'master' into aleem/8686-txevents-orderby
c301dda
Merge branch 'master' into aleem/8686-txevents-orderby
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this mean, and why do we need it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is to access API's by
enum
names.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AmauryM @aleem1314 this results in a protobuf namespace conflict: https://developers.google.com/protocol-buffers/docs/reference/go/faq#namespace-conflict. Is it possible we can remove this now and just to goproto registration using the API module?