Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyring: Add trust to macOS Keychain for caller app by default #8826

Merged
merged 3 commits into from
Mar 10, 2021

Conversation

gsora
Copy link
Contributor

@gsora gsora commented Mar 9, 2021

Description

This PR automatically trusts the calling application with its data,
avoiding all the annoying keychain popups that appears when dealing with
keys (list, add...).

closes: #8809


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

This commit automatically trusts the calling application with its data,
avoiding all the annoying keychain popups that appears when dealing with
keys (list, add...).
@codecov
Copy link

codecov bot commented Mar 9, 2021

Codecov Report

Merging #8826 (9b2d94c) into master (8f7cdaf) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8826      +/-   ##
==========================================
- Coverage   59.44%   59.44%   -0.01%     
==========================================
  Files         563      563              
  Lines       31286    31287       +1     
==========================================
  Hits        18598    18598              
- Misses      10522    10523       +1     
  Partials     2166     2166              
Impacted Files Coverage Δ
crypto/keyring/keyring.go 59.29% <0.00%> (-0.18%) ⬇️

@jgimeno
Copy link
Contributor

jgimeno commented Mar 10, 2021

👏

@alessio alessio added the A:automerge Automatically merge PR once all prerequisites pass. label Mar 10, 2021
@mergify mergify bot merged commit d761f08 into master Mar 10, 2021
@mergify mergify bot deleted the gsora/macos-keychain-less-annoying branch March 10, 2021 08:56
mergify bot pushed a commit that referenced this pull request Mar 10, 2021
This commit automatically trusts the calling application with its data,
avoiding all the annoying keychain popups that appears when dealing with
keys (list, add...).

Co-authored-by: Alessio Treglia <alessio@tendermint.com>
(cherry picked from commit d761f08)
alessio pushed a commit that referenced this pull request Mar 10, 2021
This commit automatically trusts the calling application with its data,
avoiding all the annoying keychain popups that appears when dealing with
keys (list, add...).

Co-authored-by: Alessio Treglia <alessio@tendermint.com>
(cherry picked from commit d761f08)

Co-authored-by: Gianguido Sora <gsora@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:CLI C:Keys Keybase, KMS and HSMs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI/keys: Make gaiad keys list on mac os not ask for the password for every key
4 participants