-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/upgrade: remove support for time based upgrades #8849
Changes from all commits
e349c19
30ce95f
b2ffed6
833af0a
5460e87
5d1f563
3e401a1
1e539d8
8a09779
cbf7c1a
c9be1e0
fee853d
547380c
28fe6b7
def349d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -26,6 +26,8 @@ lint: | |
breaking: | ||
use: | ||
- FILE | ||
except: | ||
- FIELD_NO_DELETE | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It would be great if we had some comments about this line indicating that this still requires reserving the name and number. Could you add quickly in a separate PR @technicallyty ? |
||
ignore: | ||
- tendermint | ||
- gogoproto | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
/* | ||
Package upgrade provides a Cosmos SDK module that can be used for smoothly upgrading a live Cosmos chain to a | ||
new software version. It accomplishes this by providing a BeginBlocker hook that prevents the blockchain state | ||
machine from proceeding once a pre-defined upgrade block time or height has been reached. The module does not prescribe | ||
machine from proceeding once a pre-defined upgrade block height has been reached. The module does not prescribe | ||
anything regarding how governance decides to do an upgrade, but just the mechanism for coordinating the upgrade safely. | ||
Without software support for upgrades, upgrading a live chain is risky because all of the validators need to pause | ||
their state machines at exactly the same point in the process. If this is not done correctly, there can be state | ||
|
@@ -21,9 +21,9 @@ perform a migration, but also to identify if this is the old or new version (eg. | |
a handler registered for the named upgrade). | ||
|
||
Once the release candidate along with an appropriate upgrade handler is frozen, | ||
we can have a governance vote to approve this upgrade at some future block time | ||
or block height (e.g. 200000). This is known as an upgrade.Plan. The v0.38.0 code will not know of this | ||
handler, but will continue to run until block 200000, when the plan kicks in at BeginBlock. It will check | ||
we can have a governance vote to approve this upgrade at some future block height (e.g. 200000). | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. thanks for thinking about this file and the SPEC 👍 |
||
This is known as an upgrade.Plan. The v0.38.0 code will not know of this handler, but will | ||
continue to run until block 200000, when the plan kicks in at BeginBlock. It will check | ||
for existence of the handler, and finding it missing, know that it is running the obsolete software, | ||
and gracefully exit. | ||
|
||
|
@@ -54,7 +54,7 @@ should call ScheduleUpgrade to schedule an upgrade and ClearUpgradePlan to cance | |
|
||
Performing Upgrades | ||
|
||
Upgrades can be scheduled at either a predefined block height or time. Once this block height or time is reached, the | ||
Upgrades can be scheduled at a predefined block height. Once this block height is reached, the | ||
existing software will cease to process ABCI messages and a new version with code that handles the upgrade must be deployed. | ||
All upgrades are coordinated by a unique upgrade name that cannot be reused on the same blockchain. In order for the upgrade | ||
module to know that the upgrade has been safely applied, a handler with the name of the upgrade must be installed. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect we want to add a
Deprecated
section and add this to that