track delegation vesting accounts

[boz]

@gsora @alexanderbez what do you guys think of this patch to the account migration?

1. reset corrupted values to zero
2. re-run TrackDelegation
3. save account with SetAccount 😅

[lgtm-com]

This pull request introduces 2 alerts and fixes 2 when merging 80335ad into c0cb1d2 - view on LGTM.com

new alerts:

• 2 for Useless assignment to local variable

fixed alerts:

• 2 for Useless assignment to local variable

[lgtm-com]

This pull request fixes 2 alerts when merging 9a1c74a into c0cb1d2 - view on LGTM.com

fixed alerts:

• 2 for Useless assignment to local variable

[lgtm-com]

This pull request fixes 2 alerts when merging 93b2ec9 into c0cb1d2 - view on LGTM.com

fixed alerts:

• 2 for Useless assignment to local variable

[lgtm-com]

This pull request fixes 2 alerts when merging c10b189 into c0cb1d2 - view on LGTM.com

fixed alerts:

• 2 for Useless assignment to local variable

[alexanderbez]

Looks reasonable to me. Any reason this is preferred over the original approach? Is the original approach broken?

[gsora]

This PR adds a more general test case and a clearing pass in the migration.

Not a completely new approach, but a rather important factor that was missing in #8865, hence the PR-on-PR :D

[boz]

Looks reasonable to me. Any reason this is preferred over the original approach? Is the original approach broken?

Small change to the previous approach - zero-out the fields and don't clamp down the delegation amount before calling TrackDelegation - this allows for delegation of more than the amount that is/was vesting.

[gsora]

I am merging this, looks fine and adds further refinements to the migration code.