-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix IBC links #9005
fix IBC links #9005
Conversation
@colin-axner right now IBC docs are shown inside a section on the left on docs.cosmos.network. Do we want to keep that, or does IBC have a plan to have its own docs page? Maybe we could just delete the |
The plan is to eventually create a docs subdomain for |
Benchmark finished. See the result: https://github.orijtech.com/benchmark/result?id=b4fd9a73f296450bb2b1e1c5bc95a1d4 |
Benchmark beginning. Status page: https://github.orijtech.com/benchmark/status?commit=447f6dcd802ee9e6c14444b78b913b0b3b03a707 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no hyphen in prerequisites
* went to fix a broken link and then got caught up in an editorial quick sweep to address style, typos, and clarity issues * typo * removed the commented out link to use cases, can replace with link to website when the site has the use cases. * get corrected links from #9005 * Update docs/ibc/overview.md Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> * Apply Colin's suggestions from code review thank you for your careful review, I appreciate you Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> * resolve merge conflict with link fixes, I hope these are correct * is like (was analogous) Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Description
copied over from ibc-go pr
closes: #8966
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes