Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/auth: update NewAccountKeeper docs #9020

Merged
merged 5 commits into from
Mar 30, 2021
Merged

x/auth: update NewAccountKeeper docs #9020

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
49a760d
x/auth: update NewAccountKeeper docs
robert-zaremba Mar 29, 2021
78ba066
Update x/auth/keeper/keeper.go
robert-zaremba Mar 30, 2021
8d47558
Merge branch 'master' into robert/new-keeper-docs
mergify[bot] Mar 30, 2021
47c1189
Update x/auth/keeper/keeper.go
robert-zaremba Mar 30, 2021
58af100
Apply suggestions from code review
robert-zaremba Mar 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions x/auth/keeper/keeper.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,10 @@ var _ AccountKeeperI = &AccountKeeper{}

// NewAccountKeeper returns a new AccountKeeperI that uses go-amino to
// (binary) encode and decode concrete sdk.Accounts.
// `maccPerms` is a map that takes accounts' addresses as keys, and their respective permissions as values. This map is used to construct
// types.PermissionsForAddress and is used in keeper.ValidatePermissions. Permissions are plain strings,
// and don't have to fit into any predefined structure. This auth module does not use account permissions internally, though other modules
// may use auth.Keeper to access the accounts permissions map.
func NewAccountKeeper(
cdc codec.BinaryMarshaler, key sdk.StoreKey, paramstore paramtypes.Subspace, proto func() types.AccountI,
maccPerms map[string][]string,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking to change the maccPerms type to map[string]types.PermissionsForAddress, but that would add redundancy when creating the parameters: PermissionsForAddress repeats the module name (the map key) in it's attributes.

Expand Down