Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cuonglm/add fuzz verify address format #9050

Merged
merged 2 commits into from
Apr 6, 2021
Merged

Cuonglm/add fuzz verify address format #9050

merged 2 commits into from
Apr 6, 2021

Conversation

cuonglm
Copy link
Contributor

@cuonglm cuonglm commented Apr 5, 2021 •
edited
Loading

Description

More fuzzing for types package.

Updates #7921

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@cuonglm
Copy link
Contributor Author

cuonglm commented Apr 5, 2021

cc @odeke-em

odeke-em
odeke-em approved these changes Apr 5, 2021
View reviewed changes
Copy link
Collaborator

@odeke-em odeke-em left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @cuonglm! We’ll examine and produce as many fuzz tests then work on submitting cosmos-sdk to oss-fuzz so that it’ll get continuously fuzzed.

amaury1093
amaury1093 approved these changes Apr 6, 2021
View reviewed changes
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. could you fix the lint errors too?

@cuonglm
Copy link
Contributor Author

cuonglm commented Apr 6, 2021

lgtm. could you fix the lint errors too?

Seems the error was fixed on master, I will create new PR to merge master into fuzz-packages

@cuonglm
Copy link
Contributor Author

cuonglm commented Apr 6, 2021

lgtm. could you fix the lint errors too?

Seems the error was fixed on master, I will create new PR to merge master into fuzz-packages

Created #9057

@amaury1093
Copy link
Contributor

I just noticed this wan't targetting master. I don't understand, why are we not merging to master directly? It seems way more work to keep full-packages up-to-date with master.

@cuonglm
Copy link
Contributor Author

cuonglm commented Apr 6, 2021

I just noticed this wan't targetting master. I don't understand, why are we not merging to master directly? It seems way more work to keep full-packages up-to-date with master.

I think @odeke-em has more background on this than me, but I guess we want to make the fuzzing stable/confidently until we can merge it to master.

@amaury1093
Copy link
Contributor

Ah, ok, sounds good then. In this case I will stop reviewing these PRs, will only review the final one into master.

@cuonglm and @odeke-em Since these PRs are not going into master, feel free to merge at will 👍

@odeke-em odeke-em merged commit 78d95b1 into cosmos:fuzz-packages Apr 6, 2021
@odeke-em odeke-em deleted the cuonglm/add-fuzz-VerifyAddressFormat branch April 6, 2021 21:09
odeke-em pushed a commit that referenced this pull request Apr 14, 2021
@odeke-em
fuzz: add types.VerifyAddressFormat (#9050)
63ce994 
Also:: fuzz: add types.ParseDecCoin

Updates #7921
odeke-em pushed a commit that referenced this pull request Apr 22, 2021
@odeke-em
fuzz: add types.VerifyAddressFormat (#9050)
6f5613d 
Also:: fuzz: add types.ParseDecCoin

Updates #7921
odeke-em pushed a commit that referenced this pull request Apr 22, 2021
@odeke-em
fuzz: add types.VerifyAddressFormat (#9050)
319f63c 
Also:: fuzz: add types.ParseDecCoin

Updates #7921
odeke-em pushed a commit that referenced this pull request Apr 24, 2021
@odeke-em
fuzz: add types.VerifyAddressFormat (#9050)
88919d5 
Also:: fuzz: add types.ParseDecCoin

Updates #7921
odeke-em pushed a commit that referenced this pull request Jul 22, 2021
@odeke-em
fuzz: add types.VerifyAddressFormat (#9050)
2457bf3 
Also:: fuzz: add types.ParseDecCoin

Updates #7921
odeke-em pushed a commit that referenced this pull request Jul 22, 2021
@odeke-em
fuzz: add types.VerifyAddressFormat (#9050)
51d7a2f 
Also:: fuzz: add types.ParseDecCoin

Updates #7921
odeke-em pushed a commit that referenced this pull request Jul 28, 2021
@odeke-em
fuzz: add types.VerifyAddressFormat (#9050)
fb6924d 
Also:: fuzz: add types.ParseDecCoin

Updates #7921
odeke-em pushed a commit that referenced this pull request Jul 28, 2021
@odeke-em
fuzz: add types.VerifyAddressFormat (#9050)
3f2de12 
Also:: fuzz: add types.ParseDecCoin

Updates #7921
odeke-em pushed a commit that referenced this pull request Mar 30, 2022
@odeke-em
fuzz: add types.VerifyAddressFormat (#9050)
3f0aac5 
Also:: fuzz: add types.ParseDecCoin

Updates #7921
odeke-em pushed a commit that referenced this pull request Mar 30, 2022
@odeke-em
fuzz: add types.VerifyAddressFormat (#9050)
daa1869 
Also:: fuzz: add types.ParseDecCoin

Updates #7921
elias-orijtech pushed a commit to elias-orijtech/cosmos-sdk that referenced this pull request Apr 11, 2022
@elias-orijtech
fuzz: add types.VerifyAddressFormat (cosmos#9050)
caf6d4e 
Also:: fuzz: add types.ParseDecCoin

Updates cosmos#7921
elias-orijtech pushed a commit to elias-orijtech/cosmos-sdk that referenced this pull request Apr 11, 2022
@elias-orijtech
fuzz: add types.VerifyAddressFormat (cosmos#9050)
8c4a9e2 
Also:: fuzz: add types.ParseDecCoin

Updates cosmos#7921
elias-orijtech pushed a commit to elias-orijtech/cosmos-sdk that referenced this pull request May 6, 2022
@elias-orijtech
fuzz: add types.VerifyAddressFormat (cosmos#9050)
a9b9a5d 
Also:: fuzz: add types.ParseDecCoin

Updates cosmos#7921
elias-orijtech pushed a commit to elias-orijtech/cosmos-sdk that referenced this pull request May 6, 2022
@elias-orijtech
fuzz: add types.VerifyAddressFormat (cosmos#9050)
b414d50 
Also:: fuzz: add types.ParseDecCoin

Updates cosmos#7921
odeke-em pushed a commit that referenced this pull request Jun 4, 2022
@odeke-em
fuzz: add types.VerifyAddressFormat (#9050)
7fa056d 
Also:: fuzz: add types.ParseDecCoin

Updates #7921
odeke-em pushed a commit that referenced this pull request Jun 4, 2022
@odeke-em
fuzz: add types.VerifyAddressFormat (#9050)
34ccf1c 
Also:: fuzz: add types.ParseDecCoin

Updates #7921
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odeke-em odeke-em odeke-em approved these changes

@amaury1093 amaury1093 amaury1093 approved these changes

@aaronc aaronc Awaiting requested review from aaronc

@alessio alessio Awaiting requested review from alessio

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cuonglm @amaury1093 @odeke-em