Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store supply as Int bytes rather than string bytes #9051

Merged
merged 11 commits into from
Apr 6, 2021

Conversation

sahith-narahari
Copy link
Contributor

@sahith-narahari sahith-narahari commented Apr 5, 2021

Description

follow up: #8798 (comment)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Apr 6, 2021

Codecov Report

Merging #9051 (c26794f) into master (5247a55) will increase coverage by 0.00%.
The diff coverage is 53.84%.

❗ Current head c26794f differs from pull request most recent head 13e8cc2. Consider uploading reports for the commit 13e8cc2 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9051   +/-   ##
=======================================
  Coverage   58.99%   58.99%           
=======================================
  Files         575      575           
  Lines       32192    32203   +11     
=======================================
+ Hits        18992    18999    +7     
- Misses      10984    10986    +2     
- Partials     2216     2218    +2     
Impacted Files Coverage Δ
x/bank/keeper/keeper.go 76.28% <50.00%> (-0.44%) ⬇️
x/bank/legacy/v043/store.go 84.61% <100.00%> (ø)
x/staking/simulation/operations.go 73.16% <0.00%> (-0.30%) ⬇️
x/staking/types/msg.go 55.55% <0.00%> (+0.62%) ⬆️

@sahith-narahari sahith-narahari mentioned this pull request Apr 6, 2021
9 tasks
Copy link
Contributor

@jgimeno jgimeno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one, thanks Sahith!

@jgimeno jgimeno added this to the v0.43 milestone Apr 6, 2021
@jgimeno jgimeno added the backlog label Apr 6, 2021
@sahith-narahari sahith-narahari marked this pull request as ready for review April 6, 2021 09:06
x/bank/keeper/keeper.go Outdated Show resolved Hide resolved
x/bank/keeper/keeper.go Outdated Show resolved Hide resolved
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks. Could you update the SPEC 01_state.md too?

@amaury1093 amaury1093 added A:automerge Automatically merge PR once all prerequisites pass. and removed A:automerge Automatically merge PR once all prerequisites pass. labels Apr 6, 2021
Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK pending changelog entry

@fedekunze fedekunze removed the A:automerge Automatically merge PR once all prerequisites pass. label Apr 6, 2021
@amaury1093 amaury1093 added the A:automerge Automatically merge PR once all prerequisites pass. label Apr 6, 2021
@mergify mergify bot merged commit 4b2fc3b into master Apr 6, 2021
@mergify mergify bot deleted the sahith/update-supply branch April 6, 2021 14:01
@aaronc aaronc removed the backlog label Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants