Backport #9081: bump tendermint core #9082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Depends on 0.34.9.
alessio
requested review from
gsora,
tessr,
robert-zaremba,
amaury1093,
jgimeno,
shahankhatch,
tac0turtle and
fdymylja
clevinson
reviewed
Apr 8, 2021
| @@ -410,7 +409,7 @@ func (s *IntegrationTestSuite) TestQueryDelegationsResponseCode() { | |||
| val := s.network.Validators[0] | |||
|
|
|||
| // Create new account in the keyring. | |||
| info, _, err := val.ClientCtx.Keyring.NewMnemonic("test", keyring.English, sdk.FullFundraiserPath, keyring.DefaultBIP39Passphrase, hd.Secp256k1) | |||
| info, _, err := val.ClientCtx.Keyring.NewMnemonic("test", keyring.English, sdk.FullFundraiserPath, hd.Secp256k1) | |||
There was a problem hiding this comment.
@alessio can you clarify what this is doing, and why this is necessary here?
There was a problem hiding this comment.
API change introduced in the keyring. The build was broken since 5aec5e6 was merged in
There was a problem hiding this comment.
@alessio the commit you link here is the one from this PR. Is there another commit with the actual prior change? I'd like to understand if we need to have this fixed on master, or if not, why this has diverged?
There was a problem hiding this comment.
Answering my own question here. The new keyring api on master has not actually been backported to v0.42.x yet, so this needs to diverge from master until we backport the keyring API to v0.42.x
robert-zaremba
approved these changes
Apr 8, 2021
shahankhatch
approved these changes
Apr 8, 2021
clevinson
approved these changes
Apr 8, 2021
aaronc
approved these changes
Apr 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From: #9081
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes