Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix show multisig query #9108

Merged
merged 4 commits into from
Apr 16, 2021
Merged

fix show multisig query #9108

merged 4 commits into from
Apr 16, 2021

Conversation

atheeshp
Copy link
Contributor

Description

closes: #9056


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@atheeshp atheeshp marked this pull request as ready for review April 14, 2021 08:21
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, could you add a changlog entry?

@amaury1093 amaury1093 added this to the v0.42.5 milestone Apr 14, 2021
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

➜  cosmos-sdk git:(atheesh/fix-show-multisig) ./build/simd keys show mk3 --keyring-backend test
- name: mk3
  type: multi
  address: cosmos15xjj24y9wavnze4k7tgyyjtlx33g2d069g2f5e
  pubkey: cosmospub1ytql0csgqyfzd666axrjzq3vu44gvysmpx8mr4j8ek9uyf2rssnx3sa25tth7eunkz3s8y0zngfzd666axrjzqevkwfxfhduk48zy606neu46wclx9sds8308akqa0exwly8jgtqzq7tghgz
  mnemonic: ""
  threshold: 1
  pubkeys:
  - address: cosmos1g9cwpqvvwcltarvt8dc2v8ycest73whufunh4a
    pubkey: cosmospub1addwnpepqgkw265xzgdsnra36erumz7zy4pcgfngcw4294mlv7fmpgcrj83f5f3rpga
    weight: 1
  - address: cosmos1n88h40yg9xfav2rg7udpy7pg95pe4luqsxk4q3
    pubkey: cosmospub1addwnpepqvkt8ynymk7t2n3zd8afu72a8v0nzcxcrchn7mqwhun80jrey9spqrhv605
    weight: 1

@amaury1093 amaury1093 added A:automerge Automatically merge PR once all prerequisites pass. and removed A:automerge Automatically merge PR once all prerequisites pass. labels Apr 14, 2021
CHANGELOG.md Outdated Show resolved Hide resolved
@tac0turtle tac0turtle added the A:automerge Automatically merge PR once all prerequisites pass. label Apr 14, 2021
Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a test case too, please?

@atheeshp atheeshp requested a review from fedekunze April 15, 2021 11:15
@cyberbono3 cyberbono3 self-requested a review April 15, 2021 21:34
@fedekunze
Copy link
Collaborator

cc: @alessio @alexanderbez @aaronc

@alessio alessio merged commit 455c009 into release/v0.42.x Apr 16, 2021
@alessio alessio deleted the atheesh/fix-show-multisig branch April 16, 2021 23:48
@aaronc aaronc removed the backlog label Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants