Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: check docs build #9125

Merged
merged 2 commits into from
Apr 16, 2021
Merged

ci: check docs build #9125

merged 2 commits into from
Apr 16, 2021

Conversation

lovincyrus
Copy link
Contributor

Description

Ref: #9124 (comment)

  • added a workflow to run npm run build when a PR is labeled with docs
  • the workflow will check if it builds succcessfully

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@lovincyrus lovincyrus mentioned this pull request Apr 15, 2021
Merged
9 tasks
@lovincyrus lovincyrus mentioned this pull request Apr 15, 2021
Merged
12 tasks
@tac0turtle tac0turtle merged commit 0bcd7c6 into master Apr 16, 2021
@tac0turtle tac0turtle deleted the cyrus/check-docs-build branch April 16, 2021 07:46
@cuonglm cuonglm mentioned this pull request Apr 28, 2021
Merged
9 tasks
mergify bot pushed a commit that referenced this pull request Apr 30, 2021
crypto/types: optimize compact bit array one count (#9216)
72873a0 
By using bits.OnesCount8 instead of bitwise operations.

Benchmark result on Apple M1:

name                     old time/op    new time/op    delta
NumTrueBitsBefore/new-8    88.5ns ± 1%     9.1ns ± 0%  -89.68%  (p=0.000 n=10+10)

name                     old alloc/op   new alloc/op   delta
NumTrueBitsBefore/new-8     0.00B          0.00B          ~     (all equal)

name                     old allocs/op  new allocs/op  delta
NumTrueBitsBefore/new-8      0.00           0.00          ~     (all equal)

Fixes #9125
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alessio alessio alessio approved these changes

@aaronc aaronc Awaiting requested review from aaronc

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

@tac0turtle tac0turtle Awaiting requested review from tac0turtle

@sahith-narahari sahith-narahari Awaiting requested review from sahith-narahari

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lovincyrus @alessio @tac0turtle