-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
codec: Rename codec and marshaler interfaces #9226
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9226 +/- ##
=======================================
Coverage 60.03% 60.03%
=======================================
Files 595 595
Lines 37353 37353
=======================================
Hits 22425 22425
Misses 12940 12940
Partials 1988 1988
|
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Thanks for checking, yes not all places in docs were updated. I've revisit it and updated. |
Co-authored-by: Marko <marbar3778@yahoo.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks!
We happened to be using these functions in IBC. Is there a function I can migrate to that does the exact same functionality? We cannot change encoding values (ie they need to be exactly the same as before) Is it safe to go from Edit: I misread the CHANGELOG. I realize it is just the suffix that was removed (not the function itself) 👍 |
MarshalBinaryBare(o ProtoMarshaler) ([]byte, error) | ||
MustMarshalBinaryBare(o ProtoMarshaler) []byte | ||
BinaryCodec interface { | ||
// Marshal returns binary encoding of v. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is v
in the comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah should be o
. @xavierlepretre would you like to create a quick PR?
* codec: Rename codec and marshaler interfaces, ref: 8413 * codec: remove BinaryBare * changelog update * Update comments and documentation * adding doc string comments * Update CHANGELOG.md Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com> * Update codec/codec.go Co-authored-by: Marko <marbar3778@yahoo.com> Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com> Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com> Co-authored-by: Marko <marbar3778@yahoo.com>
Renames. Trying to standarize the interfaces. See the issue for more details.
closes: #8413
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes