add sorted check for the coins sub/add fun parameter #9240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robert-zaremba
requested review from
atheeshp,
clevinson,
colin-axner and
technicallyty
Codecov Report
@@ Coverage Diff @@
## master #9240 +/- ##
==========================================
+ Coverage 60.13% 60.14% +0.01%
==========================================
Files 595 595
Lines 37185 37201 +16
==========================================
+ Hits 22360 22376 +16
Misses 12846 12846
Partials 1979 1979
|
colin-axner
reviewed
May 3, 2021
atheeshp
reviewed
May 5, 2021
types/coin.go
Outdated
Comment on lines
247
to
249
| if len(coins) < 2 { | ||
| return true | ||
| } |
There was a problem hiding this comment.
I think this extra check is not necessary.
There was a problem hiding this comment.
right, the loop condition will handle it.
There was a problem hiding this comment.
This is early return. A very good practice AFAICT
robert-zaremba
added
the
A:automerge
robert-zaremba
removed
the
A:automerge
robert-zaremba
added
the
A:automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When looking at #9159 and the
Coinsstructure usage in the SDK, I noticed that we don't assure if theCoins.SubandCoins.Addis not checked if the coins are sorted. We haveIsValidatefunction, but it's not always used.NOTE: I was thinking about adding a check for the object receiver (self), but it seams we construct it correctly with a constructor (
NewCoins).Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes