Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update memo usage docs #9265

Merged
merged 5 commits into from
May 6, 2021
Merged

Update memo usage docs #9265

merged 5 commits into from
May 6, 2021

Conversation

anilcse
Copy link
Collaborator

@anilcse anilcse commented May 5, 2021

Description

closes: #9122


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@github-actions github-actions bot added the T:Docs Changes and features related to documentation. label May 5, 2021
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

proto/cosmos/tx/v1beta1/tx.proto Outdated Show resolved Hide resolved
proto/cosmos/tx/v1beta1/tx.proto Outdated Show resolved Hide resolved
anilcse and others added 2 commits May 6, 2021 12:14
Co-authored-by: Aaron Craelius <aaron@regen.network>
Co-authored-by: Aaron Craelius <aaron@regen.network>
@anilcse anilcse requested a review from aaronc May 6, 2021 06:44
@amaury1093 amaury1093 added the A:automerge Automatically merge PR once all prerequisites pass. label May 6, 2021
@mergify mergify bot merged commit 2eeb464 into master May 6, 2021
@mergify mergify bot deleted the anil/update_cli_memo_docs branch May 6, 2021 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. T:Docs Changes and features related to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"--memo" attribute is misleading
4 participants