x/bank v0.43 Audit updates #9271
Conversation
github-actions
bot
added
C:CLI
C:x/bank
T:Docs
Codecov Report
@@ Coverage Diff @@
## master #9271 +/- ##
=======================================
Coverage 60.32% 60.32%
=======================================
Files 591 591
Lines 36936 36936
=======================================
Hits 22282 22282
Misses 12683 12683
Partials 1971 1971
|
x/bank/spec/02_keepers.md
Outdated
| @@ -14,15 +14,15 @@ permissions are limited in the way that you expect. | |||
|
|
|||
| ## Blacklisting Addresses | |||
|
|
|||
| The `x/bank` module accepts a map of addresses that are considered blocklisted | |||
| The `x/bank` module accepts a map of addresses that are considered blacklisted | |||
There was a problem hiding this comment.
We need an alternative to "blacklist": https://developers.google.com/style/word-list#letter-b. This wording was intentional.
There was a problem hiding this comment.
Yeah, i was thinking about that when i was reading through the spec. How about denylist? I think i've seen a few org's make the change to denylist and allowlist.
There was a problem hiding this comment.
I don't have a strong preference personally
There was a problem hiding this comment.
Looks like blocklisted was already heavily used, just a few comments weren't changed. I'll go with blocklist
| DelegateCoins(ctx sdk.Context, delegatorAddr, moduleAccAddr sdk.AccAddress, amt sdk.Coins) error | ||
| UndelegateCoins(ctx sdk.Context, moduleAccAddr, delegatorAddr sdk.AccAddress, amt sdk.Coins) error | ||
|
|
||
| types.QueryServer |
There was a problem hiding this comment.
why this was reformatted? Go style is to use tabs.
There was a problem hiding this comment.
i repasted the keeper definitions to make sure no small changes were missed in docs - I indented using tabs for this PR and double checked my editor this morning - it is set to tabs
Description
Supplyproto message to point to correct path to interfaceSendCoinsto emit after error checkingSendEnableCoin(s)->IsSendEnabledCoin(s)ref: #9218
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes