Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove migration scripts <=0.38 #9291

Merged
merged 12 commits into from
May 11, 2021
Merged

Remove migration scripts <=0.38 #9291

merged 12 commits into from
May 11, 2021

Conversation

amaury1093
Copy link
Contributor

Description

Legacy migrations came up during v043 audit #9218. This PR removes all legacy migration scripts <=0.38.
closes #9269
closes #8678


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@amaury1093 amaury1093 force-pushed the am/9218-remove-legacy branch from 3deb068 to e0c4df5 Compare May 10, 2021 12:39
@amaury1093 amaury1093 marked this pull request as ready for review May 10, 2021 12:44
Copy link
Collaborator

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, great to remove legacy things!

@amaury1093 amaury1093 added the A:automerge Automatically merge PR once all prerequisites pass. label May 11, 2021
Copy link
Contributor

@cyberbono3 cyberbono3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mergify mergify bot merged commit 56c0595 into master May 11, 2021
@mergify mergify bot deleted the am/9218-remove-legacy branch May 11, 2021 14:01
elise-ng added a commit to elise-ng/likecoin-chain that referenced this pull request Feb 10, 2022
Ref oursky#20

Reverts likecoin@b761463

This migration depended on `github.com/cosmos/cosmos-sdk/x/genutil/legacy/v038` module which is already removed from upstream, ref: cosmos/cosmos-sdk#9291

Removing this for now; If we need to keep it, will have to resolve `v038` from an older sdk fork
hochiw pushed a commit to hochiw/likecoin-chain that referenced this pull request Feb 11, 2022
Ref oursky#20

Reverts likecoin@b761463

This migration depended on `github.com/cosmos/cosmos-sdk/x/genutil/legacy/v038` module which is already removed from upstream, ref: cosmos/cosmos-sdk#9291

Removing this for now; If we need to keep it, will have to resolve `v038` from an older sdk fork
elise-ng added a commit to elise-ng/likecoin-chain that referenced this pull request Feb 21, 2022
Ref oursky#20

Reverts likecoin@b761463

This migration depended on `github.com/cosmos/cosmos-sdk/x/genutil/legacy/v038` module which is already removed from upstream, ref: cosmos/cosmos-sdk#9291

Removing this for now; If we need to keep it, will have to resolve `v038` from an older sdk fork
elise-ng added a commit to oursky/likecoin-chain that referenced this pull request Feb 21, 2022
Ref #20

Reverts likecoin@b761463

This migration depended on `github.com/cosmos/cosmos-sdk/x/genutil/legacy/v038` module which is already removed from upstream, ref: cosmos/cosmos-sdk#9291

Removing this for now; If we need to keep it, will have to resolve `v038` from an older sdk fork
rickmak pushed a commit to oursky/likecoin-chain that referenced this pull request Feb 21, 2022
Ref #20

Reverts likecoin@b761463

This migration depended on `github.com/cosmos/cosmos-sdk/x/genutil/legacy/v038` module which is already removed from upstream, ref: cosmos/cosmos-sdk#9291

Removing this for now; If we need to keep it, will have to resolve `v038` from an older sdk fork
elise-ng added a commit to oursky/likecoin-chain that referenced this pull request Mar 14, 2022
Ref #20

Reverts likecoin@b761463

This migration depended on `github.com/cosmos/cosmos-sdk/x/genutil/legacy/v038` module which is already removed from upstream, ref: cosmos/cosmos-sdk#9291

Removing this for now; If we need to keep it, will have to resolve `v038` from an older sdk fork
elise-ng added a commit to oursky/likecoin-chain that referenced this pull request Mar 25, 2022
Ref #20

Reverts likecoin@b761463

This migration depended on `github.com/cosmos/cosmos-sdk/x/genutil/legacy/v038` module which is already removed from upstream, ref: cosmos/cosmos-sdk#9291

Removing this for now; If we need to keep it, will have to resolve `v038` from an older sdk fork
elise-ng added a commit to oursky/likecoin-chain that referenced this pull request Mar 29, 2022
Ref #20

Reverts likecoin@b761463

This migration depended on `github.com/cosmos/cosmos-sdk/x/genutil/legacy/v038` module which is already removed from upstream, ref: cosmos/cosmos-sdk#9291

Removing this for now; If we need to keep it, will have to resolve `v038` from an older sdk fork
elise-ng added a commit to oursky/likecoin-chain that referenced this pull request Apr 4, 2022
Ref #20

Reverts likecoin@b761463

This migration depended on `github.com/cosmos/cosmos-sdk/x/genutil/legacy/v038` module which is already removed from upstream, ref: cosmos/cosmos-sdk#9291

Removing this for now; If we need to keep it, will have to resolve `v038` from an older sdk fork
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:CLI C:x/auth C:x/bank C:x/distribution distribution module related C:x/evidence C:x/genutil genutil module issues C:x/gov C:x/params C:x/staking C:x/upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove x/genaccounts module from cosmos/sdk Remove legacy code <=0.38
5 participants